Pass auctionId as a argument to bidsBackHandler #4789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
added
the
needs 2nd review
|
Thanks! |
hellsingblack
pushed a commit
to SublimeSkinz/Prebid.js
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since many people are using a lambda expression its very convenient to have the auctionId being returned into the bidsBackHandler argument
Type of change
Description of change
Adds auctionId as an argument to the existing bidsBackHandler call.
We use it in order to be able to take decisions in the bidsBackHandler which is the current auction that is going to be rendered.
Since the other place the auctionId is first return is the requestBids (which is outside of the Clojure and the bidsBackHandler that is being passed as a object)