Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdOcean adapter improvement #4831

Merged
merged 30 commits into from
Feb 10, 2020
Merged

AdOcean adapter improvement #4831

merged 30 commits into from
Feb 10, 2020

Conversation

martacieslak
Copy link
Contributor

@martacieslak martacieslak commented Feb 7, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add randomized part for AdOcean endpoint for better statistics measurement and discard unnecessary responses.

Sorry, something went wrong.

@musikele
Copy link
Contributor

LGTM

@musikele musikele merged commit 872e815 into prebid:master Feb 10, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* Initial revision of adocean bid adapter (ADOCEAN-13634, ADOCEAN-13635)

* Minor fixes

* new demo placement

* formating after lint

* move request parameters to params

* adocean adpater tests

* minor fixes

* added ttl, netRevenue nad creativeId. merged with upstream

* GDPR support

* do not send empty gdpr_consent

* GDPR support

* do not send empty gdpr_consent

* AdOcean adapter: tests for gdpr_support

* remove old comment

* Added possibility to use multiple times same ad placement

* Tests for placement duplication and gdpr support.

* formating

* add randomized part to endpoint url

* fix tests after endpoint url change

Co-authored-by: Jacek Drobiecki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants