Rubicon Adapter: Add liveramp support #4863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebid.js into master-rubicon-clean
# Conflicts: # modules/advangelistsBidAdapter.js # test/spec/modules/advangelistsBidAdapter_spec.js
…ter-remote-updated
PBJS RP analytics adapter: convert to 3.0
� Conflicts: � test/spec/modules/rubiconAnalyticsAdapter_spec.js
bretg
approved these changes
Feb 14, 2020
| @@ -1082,7 +1082,8 @@ describe('S2S Adapter', function () { | |||
| lipb: { | |||
| lipbid: 'li-xyz', | |||
| segments: ['segA', 'segB'] | |||
| } | |||
| }, | |||
| idl_env: '0000-1111-2222-3333' | |||
There was a problem hiding this comment.
what is this value? (0000-1111-2222-3333)
jdwieland8282
approved these changes
Feb 20, 2020
|
|
||
| // support identityLink (aka LiveRamp) | ||
| if (bidRequest.userId.idl_env) { | ||
| data.user.ext.eids.push({ |
There was a problem hiding this comment.
The PRD was incorrect in specifying this API, it will be changed. Do not use.
|
|
||
| // support identityLink (aka LiveRamp) | ||
| if (bidRequest.userId.idl_env) { | ||
| data['tpid_liveramp.com'] = bidRequest.userId.idl_env; |
There was a problem hiding this comment.
The PRD was incorrect in specifying this API, it will be changed. Do not use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for LiveRamp userId