Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PubMatic adapter to support PM Deals #4887

Merged
merged 27 commits into from
Feb 24, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • Feature

Description of change

PubMatic adapter to support PM Deals at the slot level

@robertrmartinez
Copy link
Collaborator

@pm-harshad-mane Can you please pull the latest from master to fix the linting errors.

@pm-harshad-mane
Copy link
Contributor Author

Hello @robertrmartinez ,
I have pulled the code changes, but CI is failing for random cases.

@pm-harshad-mane
Copy link
Contributor Author

@robertrmartinez All checks have passed now.

Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@robertrmartinez robertrmartinez merged commit 01390ac into prebid:master Feb 24, 2020
@pm-harshad-mane
Copy link
Contributor Author

Thank you @robertrmartinez !

hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* PubMatic to support deals param

* more than 3 chars check added
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* PubMatic to support deals param

* more than 3 chars check added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants