Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug PixelEnabled #4901

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Fix Bug PixelEnabled #4901

merged 2 commits into from
Mar 4, 2020

Conversation

richaudience
Copy link
Contributor

Type of change

  • [ x ] Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@musikele
Copy link
Contributor

musikele commented Mar 4, 2020

Hi,
LGTM

As a suggestion, consider this syntax:

syncUrl = gdprConsent && gdprConsent.consentString ? '.....' : '....'; 

@musikele musikele merged commit 89c765b into prebid:master Mar 4, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* Fix Bug PixelEnabled

* Fix Bug Consent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants