-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sortable bid adapter #4907
Add Sortable bid adapter #4907
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @shannonAB,
Thanks for the PR!
Having gone through your code and having tested it, here are my review comments:
-
Your
SERVER_URL
is not using https. It's a strict requirement that Prebid.js v3.0.0 onwards all adapters use a secure endpoint. -
The examples given in your markdown file is not accurate. Again, with Prebid.js v3.0.0 onwards, the property sizes in adUnit object is no longer supported. Instead, you should use the mediaTypes property. For example, in case of a banner ad, you should use,
mediaTypes: {
banner: {
sizes: [[728, 90]]
}
}
Details about the Prebid.js v3.0.0 release.
- Am getting a 404 BAD REQUEST on sending a request to your endpoint. I tested with the hello world page
- use https for URL - fix examples in markdown - request to endpoint should work now
Thanks for making the changes. I was expecting one more thing in your md file, since you support native and video formats as well, can you provide some examples of those. It'll be easier for us to test that way. |
LGTM! |
* Add Sortable adapter for Prebid 3.x Update tests to reflect changes. * Add .js in imports * hostname not host: don't include port * Trivial change to trigger build: failure wasn't our adapter * More failures in other adapters * PR Feedback - use https for URL - fix examples in markdown - request to endpoint should work now * Feedback: add native and video examples
Type of change
Description of change
Add the Sortable bidder adapter.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: