fix bug related to default usersync config for image-based pixels #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
reviewed
Mar 5, 2020
| @@ -45,6 +47,20 @@ export function newUserSync(userSyncDependencies) { | |||
| let usConfig = userSyncDependencies.config; | |||
| // Update if it's (re)set | |||
| config.getConfig('userSync', (conf) => { | |||
| // if userSync.filterSettings only contains iframe, merge in default image config to ensure image pixels are fired | |||
There was a problem hiding this comment.
might want to include a link to the issue (#4864) to give more detail on why this was done (how it broke backwards compatibility).
harpere
added
needs 2nd review
pm-harshad-mane
approved these changes
Mar 6, 2020
pm-harshad-mane
added
LGTM
and removed
needs 2nd review
|
@harpere I'll submit a small follow-up PR with the minor changes you asked. I was in the process of making those additions, so I should have it available relatively soon. |
jsnellbaker
added a commit
that referenced
this pull request
Mar 6, 2020
1 task
harpere
pushed a commit
that referenced
this pull request
Mar 6, 2020
bmwcmw
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Mar 31, 2020
…ebid#4928) * fix bug related to default usersync config * fix lint error
bmwcmw
pushed a commit
to criteo-forks/Prebid.js
that referenced
this pull request
Mar 31, 2020
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
…ebid#4928) * fix bug related to default usersync config * fix lint error
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fixes #4864
This fix ensures the default userSync config (which allowed image pixels for all bidders) is properly used when a publisher only defines iframe
filterSettings. If the publisher defines their ownimageorallconfig in thefilterSettingsfield, then the default image setting is overwritten.