Fix bug in rubicon bid adapter for fpd keywords #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harpere
approved these changes
Apr 6, 2020
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
Co-authored-by: rmartinez <Rachael24!>
|
@robertrmartinez @bretg I know this has long since been merged in, but I'm curious your thoughts about this becoming a silent error? Passing invalid data now won't cause the bid to fail completely, but the publisher now has no feedback that they did something wrong. Should there at least be a debugging message when data supplied by the caller is outright ignored due to bad formatting? |
|
I'm fine with a message, but it would need to be short. Very short. The PBJS package is already too big, and error messages don't compress well. |
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
Co-authored-by: rmartinez <Rachael24!>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
If the user input non array into keywords it would break and not send bids.
Here is the new test without the isArray check: