Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RtbSape adapter #5520

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Add RtbSape adapter #5520

merged 2 commits into from
Aug 7, 2020

Conversation

ne0n
Copy link
Contributor

@ne0n ne0n commented Jul 21, 2020

Type of change

  • New bidder adapter

Description of change

Add a new bidder adapter for RtbSape

  • test parameters for validating bids
\\banner
mediaTypes: {
  banner: {
    sizes: [[300, 250]]
  }
},
bids: [
  {
    bidder: "rtbsape",
    params: {
      placeId: 553307
    }
  }
]
\\video
{
  bidder: 'rtbsape',
  params: {
    placeId: 553309
  }
}

@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2020

This pull request introduces 1 alert when merging c87e82d into bb91d54 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@mike-chowla
Copy link
Contributor

I'm not getting a bid back. Below is the request body:

{ "auctionId":"4f6170a8-fbbc-41b2-95f5-9745fe84d163", "requestId":"15117d91abe33b", "bids":[ { "bidder":"rtbsape", "params":{ "placeId":553307 }, "crumbs":{ "pubåcid":"244bbf5a-cba4-4619-80b8-e802b3fb2f52" }, "mediaTypes":{ "banner":{ "sizes":[ [ 300, 250 ] ] } }, "adUnitCode":"div-gpt-ad-1460505748561-0", "transactionId":"1b44baac-d57a-453b-88ff-3792a16f097d", "sizes":[ [ 300, 250 ] ], "bidId":"2d464cbbed174a", "bidderRequestId":"15117d91abe33b", "auctionId":"4f6170a8-fbbc-41b2-95f5-9745fe84d163", "src":"client", "bidRequestsCount":1, "bidderRequestsCount":1, "bidderWinsCount":0 } ], "timezone":"-07:00", "refererInfo":{ "referer":"http://mike3.pubmatic.com:9999/integrationExamples/gpt/hello_world.html", "reachedTop":true, "numIframes":0, "stack":[ "http://mike3.pubmatic.com:9999/integrationExamples/gpt/hello_world.html" ] } }

@mike-chowla mike-chowla self-requested a review July 29, 2020 00:58
@ne0n
Copy link
Contributor Author

ne0n commented Jul 29, 2020

@mike-chowla, sorry! It was a trouble with targeting for test campaign. Fixed it. Can you check now?

@ne0n
Copy link
Contributor Author

ne0n commented Aug 6, 2020

@mike-chowla, good day. Can you, please, merge this PR? Or maybe something wrong in code?

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 96af098 into prebid:master Aug 7, 2020
@ne0n ne0n deleted the rtbsape-adapter branch August 10, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants