Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatad Bid Adapter: Add adunit code to bid request #5567

Merged
merged 23 commits into from
Aug 6, 2020
Merged

Automatad Bid Adapter: Add adunit code to bid request #5567

merged 23 commits into from
Aug 6, 2020

Conversation

kanchika-kapoor
Copy link

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Send adunit code in bid request

  • contact email of the adapter’s maintainer: [email protected]

Kanchika - Automatad added 22 commits March 23, 2020 17:11
added automatad bid adapter
ea042d0
added automatad bid adapter readme
c2a3ab6
added automatad bidder adapter unit test
2d98d8f
updated maintainer email id for automatad adapter
9b84d57
refactored automatadBidAdapter js
85611aa
refactored automatadBidAdapter unit test
8ef416c
refactored automatadBidAdapter unit test
70e3956
added usersync code to automatad bid adapter
1d1d2cd
Added unit test for onBidWon in automatadBidAdapter_spec
8c4c2a8
removed trailing spaces
ce62f83
removed trailing space
f359711
Merge branch 'master' of https://github.com/kanchika-automatad/Prebid.js
3856574
changes for getUserSync function
3897bce
lint error fixes
88d84a1
updated usersync url
c1305a0
additional test for onBidWon function added
581472a
added ajax stub in test
6a2bf79
Merge remote-tracking branch 'upstream/master'
6652aea
updated winurl params
53e7379
lint fixes
c8c7b35
Merge remote-tracking branch 'upstream/master'
0684cb9
added adunitCode in bid request
17725dc
harpere
harpere requested changes Aug 5, 2020
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to add a test for the new param.

@harpere harpere self-assigned this Aug 5, 2020
@kanchika-kapoor
Copy link
Author

added unit test for adunit code

@harpere harpere merged commit 44e4e7a into prebid:master Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

Assignees

@harpere harpere

Labels
needs review needs unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanchika-kapoor @harpere