Added IronSource bidder tests and adapter according to specs

[liranbaruch]

Type of change

• Bugfix
• Feature
• [X ] New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Added IronSource header bidding adapter

• test parameters for validating bids

{
  bidder: 'ironSource',
  params: {
            isOrg: '56f91cd4d3e3660002000033', // Required
            floorPrice: 5.00, // Optional
            ifa: 'XXX-XXX', // Optional
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

• contact email of the adapter’s maintainer
• official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

• A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

Other information

[musikele]

1. I am trying to use isOrg: '56f91cd4d3e3660002000033' as a test parameter but I don't see a video ad, In console I get AD ERROR: VAST Error: on VASTClient.getVASTAd.validateVASTTree, no Ad in VAST tree with error code 303. Is this ok?

2. tests are covering exactly 80% of the lines of code, that is the minimum required to be accepted; anyway, I highly suggest you to add more tests for getUserSyncs, if not now, in the next submission.

3. Can you link the PR for the prebid website?

[liranbaruch]

Thank you for your review We have made sure that now ad will be returned for each call and also tests were updated Looking forward to hear from you again that everything is fine Docs PR : prebid/prebid.github.io#2180 Thank you

…

On Tue, Aug 11, 2020 at 11:41 AM Michele Nasti ***@***.***> wrote: ***@***.**** commented on this pull request. 1. I am trying to use isOrg: '56f91cd4d3e3660002000033' as a test parameter but I don't see a video ad, In console I get AD ERROR: VAST Error: on VASTClient.getVASTAd.validateVASTTree, no Ad in VAST tree with error code 303. Is this ok? 2. tests are covering exactly 80% of the lines of code, that is the minimum required to be accepted; anyway, I highly suggest you to add more tests for getUserSyncs, if not now, in the next submission. Let me know regarding the first point — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5568 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFBRRTSVFQ4AWQPGHMOKFE3SAD73TANCNFSM4PULYR6Q> .

-- Liran Baruch Opt-in & Streamrail R&D lead [image: ironSource] <http://www.ironsrc.com/> email [email protected] mobile +972-52-3544875 fax +972-77-5448273 skype lbaruch ironSource HQ - 121 Derech Menachem Begin st. Tel Aviv ironsrc.com <http://www.ironsrc.com/> This email (including any attachments) is for the sole use of the intended recipient and may contain confidential information which may be protected by legal privilege. If you are not the intended recipient, or the employee or agent responsible for delivering it to the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of this communication and/or its content is strictly prohibited. If you are not the intended recipient, please immediately notify us by reply email or by telephone, delete this email and destroy any copies. Thank you.

[musikele]

@liranbaruch
Here's what I get in Prebid logs:

Prebid MESSAGE: CALLING BIDDER ======= ironSource utils.js:244:16
Prebid MESSAGE: Emitting event for: bidRequested utils.js:244:16

XML Parsing Error: not well-formed
Location: https://hb.yellowblue.io/hb?auction_start=1597224729540&ad_unit_code=video1&tmax=3000&width=640&height=480&publisher_id=56f91cd4d3e3660002000033&floor_price=undefined&ua=Mozilla%2F5.0%20(Macintosh%3B%20Intel%20Mac%20OS%20X%2010.15%3B%20rv%3A80.0)%20Gecko%2F20100101%20Firefox%2F80.0&bid_id=2226511dd3fb3f&bidder_request_id=1684a16f3617c88&transaction_id=6d54a135-d7f4-46c0-afa5-f1a1050e920b&session_id=3d2b47c9-1733-4d6c-821d-5a4ce44a36eb&publisher_name=jita.local.net&site_domain=jita.local.net&bidder_version=4.0.0&cs_method=pixel&referrer=http%3A%2F%2Fjita.local.net%3A9999%2Ftest%2Fpages%2Finstream.html%3Fpbjs_debug%3Dtrue&page_url=http%3A%2F%2Fjita.local.net%3A9999%2Ftest%2Fpages%2Finstream.html%3Fpbjs_debug%3Dtrue
Line Number 1, Column 1:

...
[videojs-vast-vpaid] AD ERROR: VAST Error: on VASTClient.getVASTAd.validateVASTTree, no Ad in VAST tree 

I put the VAST xml tag in here https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/vastinspector and i see the "edu action" ad.

Here's my configuration

var videoAdUnit = {
        code: 'video1',
        sizes: [640,480],
        mediaTypes: {
          video: {context: 'instream',  playerSize: [640, 480]}
        },
        bids: [
          {
            bidder: 'ironSource',
            params: {
              isOrg: "56f91cd4d3e3660002000033"
            }
          }
        ]
      };

pbjs.setConfig({
  debug: true,
  cache: {
    url: 'https://prebid.adnxs.com/pbc/v1/cache' // <-- is this ok? 
  }
});

Note that I am using /test/instream.html page which I find more easy to use. just change prebid.js path from
<script src="../../build/build/prebid.js" async=true></script> to <script src="../../build/dev/prebid.js" async=true></script>.

If this is expected, let me know.

[liranbaruch]

Hi , There are two options to get the proper ad from our adserver : 1.by setting the floor price to 3.20 2.by updating the test page's settings to: pbjs.bidderSettings = { ironSource: { bidCpmAdjustment: function() { return 10.00; } } }; No problem use the default cache service from our end Please verify it works for you now

…

On Wed, Aug 12, 2020 at 1:01 PM Michele Nasti ***@***.***> wrote: @liranbaruch <https://github.com/liranbaruch> Here's what I get in Prebid logs: Prebid MESSAGE: CALLING BIDDER ======= ironSource utils.js:244:16 Prebid MESSAGE: Emitting event for: bidRequested utils.js:244:16 XML Parsing Error: not well-formed Location: https://hb.yellowblue.io/hb?auction_start=1597224729540&ad_unit_code=video1&tmax=3000&width=640&height=480&publisher_id=56f91cd4d3e3660002000033&floor_price=undefined&ua=Mozilla%2F5.0%20(Macintosh%3B%20Intel%20Mac%20OS%20X%2010.15%3B%20rv%3A80.0)%20Gecko%2F20100101%20Firefox%2F80.0&bid_id=2226511dd3fb3f&bidder_request_id=1684a16f3617c88&transaction_id=6d54a135-d7f4-46c0-afa5-f1a1050e920b&session_id=3d2b47c9-1733-4d6c-821d-5a4ce44a36eb&publisher_name=jita.local.net&site_domain=jita.local.net&bidder_version=4.0.0&cs_method=pixel&referrer=http%3A%2F%2Fjita.local.net%3A9999%2Ftest%2Fpages%2Finstream.html%3Fpbjs_debug%3Dtrue&page_url=http%3A%2F%2Fjita.local.net%3A9999%2Ftest%2Fpages%2Finstream.html%3Fpbjs_debug%3Dtrue Line Number 1, Column 1: ... [videojs-vast-vpaid] AD ERROR: VAST Error: on VASTClient.getVASTAd.validateVASTTree, no Ad in VAST tree I put the VAST xml tag in here https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/vastinspector and i see the "edu action" ad. Here's my configuration var videoAdUnit = { code: 'video1', sizes: [640,480], mediaTypes: { video: {context: 'instream', playerSize: [640, 480]} }, bids: [ { bidder: 'ironSource', params: { isOrg: "56f91cd4d3e3660002000033" } } ] }; pbjs.setConfig({ debug: true, cache: { url: 'https://prebid.adnxs.com/pbc/v1/cache' // <-- is this ok? } }); Note that I am using /test/instream.html page which I find more easy to use. just change prebid.js path from `<script src="../../build/build/prebid.js" async=true></script>` to `<script src="../../build/dev/prebid.js" async=true></script>`. If this is expected, let me know. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5568 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFBRRTWWN425LEAPAG265I3SAJSBNANCNFSM4PULYR6Q> .

-- Liran Baruch Opt-in & Streamrail R&D lead [image: ironSource] <http://www.ironsrc.com/> email [email protected] mobile +972-52-3544875 fax +972-77-5448273 skype lbaruch ironSource HQ - 121 Derech Menachem Begin st. Tel Aviv ironsrc.com <http://www.ironsrc.com/> This email (including any attachments) is for the sole use of the intended recipient and may contain confidential information which may be protected by legal privilege. If you are not the intended recipient, or the employee or agent responsible for delivering it to the intended recipient, you are hereby notified that any use, dissemination, distribution or copying of this communication and/or its content is strictly prohibited. If you are not the intended recipient, please immediately notify us by reply email or by telephone, delete this email and destroy any copies. Thank you.

[musikele]

LGTM, waiting for CircleCI to be green.