Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMX support for video instream and more user id support #5618

Merged
merged 50 commits into from
Aug 20, 2020
Merged

DMX support for video instream and more user id support #5618

merged 50 commits into from
Aug 20, 2020

Conversation

stevealliance
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Update DMX adapter to support video
Bug on user id now corrected
Test with prebid version 4.0+

Steve Alliance and others added 30 commits November 17, 2016 18:09
adding DMX
5711b57 
test @97%, two files added one updated
@stevealliance
Update districtm_spec.js
ad33b56
@stevealliance
Update districtmDMX.js
fbd31ff
updating repo fork in github
fe94313
@stevealliance
Merge pull request #1 from prebid/master
6054a04 
update my fork
adding all districtm needed file
0384c75
remove legacy file
d2f5de2
remove typo || 0 in the test method
d83db11
force default to return a valid width and height
a7d0a85
update unit test code for failing test
d73cac7
changed class for an object
d5b2617
remove package-lock.json
c80b0df
change file name for dmx adapter
afa5d3e
remove package-lock.json
4e93b06
update fork
afdbd9e
renamed files
5cc3181
restaure package-lock.json
e3e864d
update to last package-lock state
6af65f9
Merge branch 'master' of https://github.com/prebid/Prebid.js
4da8f60
Merge branch 'master' of https://github.com/prebid/Prebid.js
15954f2
update gdpr user consent
af73067
fix sizes issue
c2e2f5f
@lsv1
Documentation updates
0f83dab 
Adding the readme.md info
@stevealliance
Merge pull request #3 from lsv1/patch-1
787e1e0 
Documentation updates
Merge branch 'master' of https://github.com/prebid/Prebid.js
a63b92b
update file name and update unit testing import file location
3dfb282
Merge branch 'master' of https://github.com/stevealliance/Prebid.js
5786375
update remote to reflect forked repo
60f693e
Mdding all file to localserge branch 'master' of github.com:prebid/Pr…
1f03347 
…ebid.js
current machine state
a3d85d7
Steve Alliance and others added 16 commits October 23, 2019 14:53
lint correction
a327932
remove variable assigment duplicate
1706bd1
@steve-a-districtm
adding change to dmx
9492b32
@stevealliance
Merge pull request #4 from prebid/master
5660324 
Update full repo
@steve-a-districtm
adding CCPA support for DMX
f006e29
@steve-a-districtm
adding test for ccpa and gdpr
c6b689b
@stevealliance
districtm dmx adding deal id field
c57fc3b
@steve-a-districtm
idsync support ccpa & gdpr
f31582b
@stevealliance
Merge pull request #5 from prebid/master
774dd31 
updating master
@steve-a-districtm
merge remote-tracking branch 'upstream/master'
1487845
@stevealliance
Merge remote-tracking branch 'upstream/master'
3836393
@stevealliance
Adding code getProtocols and gegtApi function + video object support
c62d8eb
@stevealliance
Resolve userId detection on dmx
cc46eb2
@stevealliance
adding support for video and vast support inline and wrap
e253f24
@stevealliance
Change video setting to be only taken from mediaTypes object from pla…
3049584 
…cement setting
@stevealliance
Adding documentation for video support
45fd0c5
patmmccann
patmmccann requested changes Aug 17, 2020
View reviewed changes
modules/districtmDMXBidAdapter.js Outdated Show resolved Hide resolved
modules/districtmDMXBidAdapter.js Outdated Show resolved Hide resolved
patmmccann
patmmccann approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the changes!

@idettman idettman merged commit 67d184a into prebid:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

@idettman idettman idettman approved these changes

Assignees

@idettman idettman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevealliance @idettman @patmmccann @lsv1 @steve-a-districtm