Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AdNow bid Adaptor #5713

Closed
wants to merge 4 commits into from
Closed

Add AdNow bid Adaptor #5713

wants to merge 4 commits into from

Conversation

vingood
Copy link
Contributor

@vingood vingood commented Sep 8, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other
  • test parameters for validating bids
{
  bidder: 'adnow',
  params: {
    codeId: 794934
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: [email protected]
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ncolletti
Copy link
Contributor

Please include a markdown file, more information on what's expected can be found here.

modules/adnowBidAdapter.js Outdated Show resolved Hide resolved
modules/adnowBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/adnowBidAdapter_spec.js Outdated Show resolved Hide resolved
test/spec/modules/adnowBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/adnowBidAdapter.js Outdated Show resolved Hide resolved
test/spec/modules/adnowBidAdapter_spec.js Outdated Show resolved Hide resolved
modules/adnowBidAdapter.js Outdated Show resolved Hide resolved
modules/adnowBidAdapter.js Outdated Show resolved Hide resolved
@vingood
Copy link
Contributor Author

vingood commented Sep 9, 2020

Your comments were taken into account. I've update the PR.

- Use only secure endpoint.
- Use adUnit mediaTypes instead of mediaType param in buildRequests.
- Pass correct sizes to the endpoint for banner and native.
- Fix adnowBidAdaper.md examples.
- Fix and add new tests in adnowBidAdaper_spec.js
@patmmccann
Copy link
Collaborator

patmmccann commented Sep 11, 2020

Please remove all your changes to package-lock.json and submit them in a different pr if you still want them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants