AdTrue Bid Adapter: getUserSyncs logic update

modules/adtrueBidAdapter.js

@@ -14,9 +14,8 @@ const UNDEFINED = undefined;
 const DEFAULT_WIDTH = 0;
 const DEFAULT_HEIGHT = 0;
 const NET_REVENUE = false;
-const USER_SYNC_URL_IFRAME = 'https://hb.adtrue.com/prebid/usersync?t=iframe&p=';
-const USER_SYNC_URL_IMAGE = 'https://hb.adtrue.com/prebid/usersync?t=img&p=';
 let publisherId = 0;
+let zoneId = 0;
 let NATIVE_ASSET_ID_TO_KEY_MAP = {};
 const DATA_TYPES = {
   'NUMBER': 'number',
@@ -25,6 +24,11 @@ const DATA_TYPES = {
   'ARRAY': 'array',
   'OBJECT': 'object'
 };
+const SYNC_TYPES = Object.freeze({
+  1: 'iframe',
+  2: 'image'
+});
+
 const VIDEO_CUSTOM_PARAMS = {
   'mimes': DATA_TYPES.ARRAY,
   'minduration': DATA_TYPES.NUMBER,
@@ -478,6 +482,7 @@ export const spec = {
       return;
     }
     publisherId = conf.pubId.trim();
+    zoneId = conf.zoneId.trim();
 
     payload.site.publisher.id = conf.pubId.trim();
     payload.ext.wrapper = {};
@@ -606,32 +611,22 @@ export const spec = {
     return bidResponses;
   },
   getUserSyncs: function (syncOptions, responses, gdprConsent, uspConsent) {
-    let syncurl = '' + publisherId;
-
-    if (gdprConsent) {
-      syncurl += '&gdpr=' + (gdprConsent.gdprApplies ? 1 : 0);
-      syncurl += '&gdpr_consent=' + encodeURIComponent(gdprConsent.consentString || '');
-    }
-    if (uspConsent) {
-      syncurl += '&us_privacy=' + encodeURIComponent(uspConsent);
-    }
-
-    // coppa compliance
-    if (config.getConfig('coppa') === true) {
-      syncurl += '&coppa=1';
-    }
-
-    if (syncOptions.iframeEnabled) {
-      return [{
-        type: 'iframe',
-        url: USER_SYNC_URL_IFRAME + syncurl
-      }];
-    } else {
-      return [{
-        type: 'image',
-        url: USER_SYNC_URL_IMAGE + syncurl
-      }];
+    if (!responses || responses.length === 0 || (!syncOptions.iframeEnabled && !syncOptions.pixelEnabled)) {
+      return [];
     }
+    return responses.filter(rsp => rsp.body && rsp.body.ext && rsp.body.ext.cookie_sync)
+      .map(rsp => rsp.body.ext.cookie_sync)
+      .reduce((a, b) => a.concat(b), [])
+      .map(({url, type}) => ({
+        type: SYNC_TYPES[type],
+        url: url +
+          '&publisherId=' + publisherId +
+          '&zoneId=' + zoneId +
+          '&gdpr=' + (gdprConsent ? (gdprConsent.gdprApplies ? 1 : 0) : 0) +
+          '&gdpr_consent=' + encodeURIComponent((gdprConsent ? gdprConsent.consentString : '')) +
+          '&us_privacy=' + encodeURIComponent((uspConsent || '')) +
+          '&coppa=' + (config.getConfig('coppa') === true ? 1 : 0)
+      }));
   }
 };
 registerBidder(spec);

test/spec/modules/adtrueBidAdapter_spec.js

@@ -48,34 +48,42 @@ describe('AdTrueBidAdapter', function () {
       }
     ];
     bidResponses = {
-      'body': {
-        'id': '1610681506302',
-        'seatbid': [
+      body: {
+        id: '1610681506302',
+        seatbid: [
           {
-            'bid': [
+            bid: [
               {
-                'id': '1',
-                'impid': '201fb513ca24e9',
-                'price': 2.880000114440918,
-                'burl': 'https://hb.adtrue.com/prebid/win-notify?impid=1610681506302&wp=${AUCTION_PRICE}',
-                'adm': '<a href=\'https://adtrue.com?ref=pbjs\' target=\'_blank\'><img src=\'http://cdn.adtrue.com/img/prebid_sample_300x250.jpg?v=1.2\' style=\' width: 300px; \' /></a>',
-                'adid': '1610681506302',
-                'adomain': [
+                id: '1',
+                impid: '201fb513ca24e9',
+                price: 2.880000114440918,
+                burl: 'https://hb.adtrue.com/prebid/win-notify?impid=1610681506302&wp=${AUCTION_PRICE}',
+                adm: '<a href=\'https://adtrue.com?ref=pbjs\' target=\'_blank\'><img src=\'http://cdn.adtrue.com/img/prebid_sample_300x250.jpg?v=1.2\' style=\' width: 300px; \' /></a>',
+                adid: '1610681506302',
+                adomain: [
                   'adtrue.com'
                 ],
-                'cid': 'f6l0r6n',
-                'crid': 'abc77au4',
-                'attr': [],
-                'w': 300,
-                'h': 250
+                cid: 'f6l0r6n',
+                crid: 'abc77au4',
+                attr: [],
+                w: 300,
+                h: 250
               }
             ],
-            'seat': 'adtrue',
-            'group': 0
+            seat: 'adtrue',
+            group: 0
           }
         ],
-        'bidid': '1610681506302',
-        'cur': 'USD'
+        bidid: '1610681506302',
+        cur: 'USD',
+        ext: {
+          cookie_sync: [
+            {
+              type: 1,
+              url: 'https://hb.adtrue.com/prebid/usersync?bidder=adtrue'
+            }
+          ]
+        }
       }
     };
   });
@@ -349,8 +357,7 @@ describe('AdTrueBidAdapter', function () {
     });
   });
   describe('getUserSyncs', function () {
-    let USER_SYNC_URL_IFRAME = 'https://hb.adtrue.com/prebid/usersync?t=iframe&p=1212';
-    let USER_SYNC_URL_IMAGE = 'https://hb.adtrue.com/prebid/usersync?t=img&p=1212';
+    let USER_SYNC_URL_IFRAME = 'https://hb.adtrue.com/prebid/usersync?bidder=adtrue&publisherId=1212&zoneId=21423&gdpr=0&gdpr_consent=&us_privacy=&coppa=0';
     let sandbox;
     beforeEach(function () {
       sandbox = sinon.sandbox.create();
@@ -359,12 +366,9 @@ describe('AdTrueBidAdapter', function () {
       sandbox.restore();
     });
     it('execute as per config', function () {
-      expect(spec.getUserSyncs({iframeEnabled: true}, {}, undefined, undefined)).to.deep.equal([{
+      expect(spec.getUserSyncs({iframeEnabled: true}, [bidResponses], undefined, undefined)).to.deep.equal([{
         type: 'iframe', url: USER_SYNC_URL_IFRAME
       }]);
-      expect(spec.getUserSyncs({iframeEnabled: false}, {}, undefined, undefined)).to.deep.equal([{
-        type: 'image', url: USER_SYNC_URL_IMAGE
-      }]);
     });
   });
 });