Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kobler Bid Adapter: add new bid adapter #6479

Merged
merged 31 commits into from
Apr 21, 2021
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
bb33686
Implemented Kobler bidder adapter.
acsbendi Mar 11, 2021
87c0594
Added missing '' to dealId example in parameters table.
acsbendi Mar 11, 2021
c8b1461
Added information on supporting the Floors module.
acsbendi Mar 12, 2021
ec1a8e2
Implemented tests for isBidRequestValid.
acsbendi Mar 12, 2021
05bb12a
Implemented tests for inherited functions.
acsbendi Mar 12, 2021
4cdbad9
Removed unnecessary conditions and quotation marks.
acsbendi Mar 12, 2021
5918e2f
Added TODO about deciding what to do in debug mode.
acsbendi Mar 12, 2021
1a28e89
Added TODO about checking which currencies are allowed.
acsbendi Mar 12, 2021
c97e3ca
Added information on parameters read from the first bid only.
acsbendi Mar 12, 2021
4be7e1d
Fixed missing indexing operator when checking if mainSize is 0x0.
acsbendi Mar 12, 2021
da4d98b
Implemented tests for buildRequests.
acsbendi Mar 12, 2021
a3efb92
Implemented tests for interpretResponse.
acsbendi Mar 15, 2021
f359949
Implemented tests for onBidWon.
acsbendi Mar 15, 2021
0e55bcf
Implemented tests for onTimeout.
acsbendi Mar 15, 2021
2651d2d
Added some missing semicolons.
acsbendi Mar 15, 2021
cd7e4b0
Removed TODO about allowed currencies.
acsbendi Mar 15, 2021
00d29fb
Removed setting test in debug mode and related TODOs.
acsbendi Mar 17, 2021
e42c8d6
Removed optional pos parameter.
acsbendi Mar 18, 2021
39e62bf
Removed optional bidfloor parameter and use floorPrice instead of flo…
acsbendi Mar 18, 2021
ffbcbec
Added support for multiple deal ID parameters.
acsbendi Mar 23, 2021
9e8d90d
Merge pull request #2 from Essens/kobler-adapter
acsbendi Mar 24, 2021
6f5a1c1
Fixed formatting.
acsbendi Mar 26, 2021
450abe4
Merge remote-tracking branch 'upstream/master'
acsbendi Mar 26, 2021
5a0485b
Added more explanation about the value of position param.
acsbendi Apr 6, 2021
27c9ad7
Moved pos property into Kobler-specific banner extension.
acsbendi Apr 7, 2021
e37de50
Simplifications based on PR comments.
acsbendi Apr 8, 2021
cd3fca8
Use getRefererInfo to get page URL for timeout notifications.
acsbendi Apr 13, 2021
8e75720
Merge remote-tracking branch 'upstream/master'
acsbendi Apr 13, 2021
0ae9e5f
Removed TODO about auction type.
acsbendi Apr 13, 2021
866d57c
Added information on how to generate a sample bid.
acsbendi Apr 15, 2021
8e6a8a7
Removed reading currency from currency.adServerCurrency.
acsbendi Apr 20, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added TODO about deciding what to do in debug mode.
  • Loading branch information
acsbendi committed Mar 12, 2021
commit 5918e2f6c24a7cc99f5278094004af0ad3b5c60d
1 change: 1 addition & 0 deletions modules/koblerBidAdapter.js
Original file line number Diff line number Diff line change
@@ -155,6 +155,7 @@ function getGeo(validBidRequest) {
}

function getTest(validBidRequest) {
// TODO: should we make the request unbillable by setting test to 1 if debug mode is turned on? (pbjs_debug)
return validBidRequest.params.test || config.getConfig('debug') ? 1 : 0;
}