Core PBjs : add check for empty mediaquery declaration in sizeConfig object #6498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jsnellbaker
added
the
needs 2nd review
msm0504
approved these changes
Apr 6, 2021
ChrisHuie
removed
the
needs 2nd review
ChrisHuie
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
We have allowed
mediaQueryproperty in sizeConfig to be declared as an empty string. This can lead to some inconsistencies as described hereThis can be a breaking change for some publishers who maybe using empty mediaQuery declarations in their sizeConfigs. This PR should go out in a major release of Prebid.js
Fixes #4810
Please refer to #4691 for a detailed context.