-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset Digital Bid Adapter: add new bid adapter #6710
Conversation
@evanmsmrtb Also will need docs PR for this bidder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must return advertiserDomains
@evanmsmrtb can you please resolve lint errors on this? |
@evanmsmrtb also Patrick's comment regarding advertiserDomains needs to be addressed as well before we can move forward with this |
docs PR prebid/prebid.github.io#2967 |
* Add alias, update valid opts * Update bidder tests * Initial ResetDigital adapter * Update resetdigital checks * Use prebid utils for domain info * Address lint and adomain items
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information