-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BidsCube Bid Adapter: add new adapter #6730
Conversation
docs PR prebid/prebid.github.io#2944 |
All done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must return advertiserDomains
@vlaktion The latest changes allowed me to get data from your server when using my test page. I've approved the PR. However, before I merge it, please address @patmmccann's comment from last week. |
@patmmccann I see the advertiserDomains is Optional. I don't have this information. Can you approve my PR? |
@patmmccann All done! For test: |
Excellent! Can you add a unit test that demonstrates meta.advertiserDomains is set in the interpreted response? |
@patmmccann Added a unit test that demonstrates meta.advertiserDomains is set in the interpreted response |
Hi. Why is BidsCube adapter don`t exist in https://docs.prebid.org/download.html? |
@patmmccann Hi. Can you answer on my question? |
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information