Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BidsCube Bid Adapter: add new adapter #6730

Merged
merged 6 commits into from
Jun 4, 2021
Merged

BidsCube Bid Adapter: add new adapter #6730

merged 6 commits into from
Jun 4, 2021

Conversation

vlaktion
Copy link
Contributor

@vlaktion vlaktion commented May 10, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie ChrisHuie changed the title New Adapter: BidsCube BidsCube Bid Adapter: add new adapter May 10, 2021
@jsnellbaker jsnellbaker requested a review from msm0504 May 10, 2021 14:18
modules/bidscubeBidAdapter.js Outdated Show resolved Hide resolved
modules/bidscubeBidAdapter.js Show resolved Hide resolved
modules/bidscubeBidAdapter.md Outdated Show resolved Hide resolved
modules/bidscubeBidAdapter.md Outdated Show resolved Hide resolved
@bretg
Copy link
Collaborator

bretg commented May 10, 2021

docs PR prebid/prebid.github.io#2944

@vlaktion
Copy link
Contributor Author

All done

Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must return advertiserDomains

@patmmccann
Copy link
Collaborator

@vlaktion reminder that you must return advertiserDomains, see #6650 for reference

@msm0504
Copy link
Contributor

msm0504 commented Jun 1, 2021

@vlaktion The latest changes allowed me to get data from your server when using my test page. I've approved the PR.

However, before I merge it, please address @patmmccann's comment from last week.

@vlaktion
Copy link
Contributor Author

vlaktion commented Jun 2, 2021

@patmmccann I see the advertiserDomains is Optional. I don't have this information. Can you approve my PR?

@vlaktion
Copy link
Contributor Author

vlaktion commented Jun 3, 2021

@patmmccann All done! For test:
POST https://supply.bidscube.com/?c=o&m=multi
{
"bidId": "9ec5b177515ee2e5",
"bidder": "bidscube",
"placements": [{
"placementId": 0,
"traffic": "banner",
"allParams": "{}"
}]
}

@patmmccann
Copy link
Collaborator

Excellent! Can you add a unit test that demonstrates meta.advertiserDomains is set in the interpreted response?

@vlaktion
Copy link
Contributor Author

vlaktion commented Jun 4, 2021

@patmmccann Added a unit test that demonstrates meta.advertiserDomains is set in the interpreted response

@patmmccann patmmccann merged commit bc2f964 into prebid:master Jun 4, 2021
@vlaktion
Copy link
Contributor Author

Hi. Why is BidsCube adapter don`t exist in https://docs.prebid.org/download.html?

@vlaktion
Copy link
Contributor Author

@patmmccann Hi. Can you answer on my question?

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants