Single Adform adapter #6840
Merged
Single Adform adapter #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6580bf4)
3 tasks
There was a problem hiding this comment.
I think this PR should only remove adform bid adapter? You shouldn't be adding changes to the adfBidAdapter since those changes are already merged in #6726.
|
Should I revert commit 0ada455 ? Changes would be applied by some later merge from master? |
|
Yes, as I see you only need 1st commit, which removes |
…rebid#6726)" This reverts commit 0ada455.
|
did your fix for #6650 geet removed from this pr? |
|
as @FilipStamenkovic noticed - it's ok to have it only in master branch. Later changes will be merged. |
|
confirming i see it on master, ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Removed legacy Adform adapter, since prebid 5.0 only adf adapter should be used to fetch Adform demand.
contact email of the adapter’s maintainer [email protected]
official adapter submission
A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/
Single adform bid adapter prebid.github.io#2991
Other information
Fixes #6650