Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invamia Bid Adapter: add new bid adapter #6941

Merged
merged 10 commits into from
Jun 9, 2021
Merged

Invamia Bid Adapter: add new bid adapter #6941

merged 10 commits into from
Jun 9, 2021

Conversation

llays
Copy link
Contributor

@llays llays commented Jun 4, 2021 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: 'invamia',
  params: {
    zoneId: 379783,
  }
}

@llays llays mentioned this pull request Jun 4, 2021
Merged
@llays llays marked this pull request as ready for review June 4, 2021 12:22
@harpere harpere requested a review from FilipStamenkovic June 7, 2021 15:21
FilipStamenkovic
FilipStamenkovic suggested changes Jun 8, 2021
View reviewed changes
modules/invamiaBidAdapter.js Outdated Show resolved Hide resolved
modules/invamiaBidAdapter.js Outdated Show resolved Hide resolved
@llays llays requested a review from FilipStamenkovic June 8, 2021 13:54
@FilipStamenkovic FilipStamenkovic merged commit 99a51e0 into prebid:master Jun 9, 2021
@FilipStamenkovic
Copy link
Contributor

@llays One thing I forgot to check in your adapter is adomain, now I see your adapter doesn't support it. You can read more about it in this issue: #5966 .

Can you please open new PR to add support?

This was referenced Jun 11, 2021
Closed
Merged
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@llays @agrandes-tappx
Invamia Bid Adapter: add new bid adapter (prebid#6941)
4021826 
* Added invamia bia adapter

* Changed serialization method

* Replaced URLSearchParams in tests as it's not supported by Circle CI

* Delete package-lock.json

* revert changes on package-lock

* Revert "Changed serialization method"

This reverts commit 4fc0ad3

* Changed serialization method

* Cache bid request params in local variable

* Implemented multiple bid support

* Updated tests

Co-authored-by: Andrew Lays <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipStamenkovic FilipStamenkovic Awaiting requested review from FilipStamenkovic

Assignees

@FilipStamenkovic FilipStamenkovic

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@llays @FilipStamenkovic @ChrisHuie @harpere