Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inskin, Consumable, FreewheelSSP Bid Adapters: Placeholder for advertiserDomains #6950

Merged
merged 11 commits into from
Jun 4, 2021
Merged

Inskin, Consumable, FreewheelSSP Bid Adapters: Placeholder for advertiserDomains #6950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2dbe9f6
Update consumableBidAdapter.js
patmmccann Jun 4, 2021
cdcea79
Update inskinBidAdapter.js
patmmccann Jun 4, 2021
69b23ae
Update freewheel-sspBidAdapter.js
patmmccann Jun 4, 2021
62d99ea
Update consumableBidAdapter_spec.js
patmmccann Jun 4, 2021
abb9d9d
Update freewheel-sspBidAdapter_spec.js
patmmccann Jun 4, 2021
68cd3f3
Update inskinBidAdapter_spec.js
patmmccann Jun 4, 2021
aa33068
Update consumableBidAdapter.js
patmmccann Jun 4, 2021
f1e0b1e
Update inskinBidAdapter.js
patmmccann Jun 4, 2021
ff9be55
Update freewheel-sspBidAdapter.js
patmmccann Jun 4, 2021
d37bfe2
Update consumableBidAdapter.js
patmmccann Jun 4, 2021
917d6ab
Update freewheel-sspBidAdapter_spec.js
patmmccann Jun 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/consumableBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export const spec = {
bid.currency = 'USD';
bid.creativeId = decision.adId;
bid.ttl = 30;
bid.meta = { advertiserDomains: decision.adomain ? decision.adomain : [] }
bid.netRevenue = true;
bid.referrer = bidRequest.bidderRequest.refererInfo.referer;

Expand Down
1 change: 1 addition & 0 deletions modules/freewheel-sspBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,7 @@ export const spec = {
currency: princingData.currency,
netRevenue: true,
ttl: 360,
meta: { advertiserDomains: princingData.adomain && utils.isArray(princingData.adomain) ? princingData.adomain : [] },
dealId: dealId,
campaignId: campaignId,
bannerId: bannerId
Expand Down
1 change: 1 addition & 0 deletions modules/inskinBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ export const spec = {
bid.currency = 'USD';
bid.creativeId = decision.adId;
bid.ttl = 360;
bid.meta = { advertiserDomains: decision.adomain ? decision.adomain : [] }
bid.netRevenue = true;

bidResponses.push(bid);
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/consumableBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ describe('Consumable BidAdapter', function () {
expect(b).to.have.property('currency', 'USD');
expect(b).to.have.property('creativeId');
expect(b).to.have.property('ttl', 30);
expect(b.meta).to.have.property('advertiserDomains');
expect(b).to.have.property('netRevenue', true);
expect(b).to.have.property('referrer');
});
Expand Down
8 changes: 4 additions & 4 deletions test/spec/modules/freewheel-sspBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ describe('freewheelSSP BidAdapter Test', () => {
];

let result = spec.interpretResponse(response, request[0]);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
expect(result[0].meta.advertiserDomains).to.deep.equal([]);
expect(result[0].dealId).to.equal('NRJ-PRO-00008');
expect(result[0].campaignId).to.equal('SMF-WOW-55555');
expect(result[0].bannerId).to.equal('12345');
Expand All @@ -395,7 +395,7 @@ describe('freewheelSSP BidAdapter Test', () => {
];

let result = spec.interpretResponse(response, request[0]);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
expect(result[0].meta.advertiserDomains).to.deep.equal([]);
expect(result[0].dealId).to.equal('NRJ-PRO-00008');
expect(result[0].campaignId).to.equal('SMF-WOW-55555');
expect(result[0].bannerId).to.equal('12345');
Expand Down Expand Up @@ -522,7 +522,7 @@ describe('freewheelSSP BidAdapter Test', () => {
];

let result = spec.interpretResponse(response, request[0]);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
expect(result[0].meta.advertiserDomains).to.deep.equal([]);
expect(result[0].dealId).to.equal('NRJ-PRO-00008');
expect(result[0].campaignId).to.equal('SMF-WOW-55555');
expect(result[0].bannerId).to.equal('12345');
Expand Down Expand Up @@ -551,7 +551,7 @@ describe('freewheelSSP BidAdapter Test', () => {
];

let result = spec.interpretResponse(response, request[0]);
expect(Object.keys(result[0])).to.deep.equal(Object.keys(expectedResponse[0]));
expect(result[0].meta.advertiserDomains).to.deep.equal([]);
expect(result[0].dealId).to.equal('NRJ-PRO-00008');
expect(result[0].campaignId).to.equal('SMF-WOW-55555');
expect(result[0].bannerId).to.equal('12345');
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/inskinBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ describe('InSkin BidAdapter', function () {
expect(b).to.have.property('currency', 'USD');
expect(b).to.have.property('creativeId');
expect(b).to.have.property('ttl', 360);
expect(b.meta).to.have.property('advertiserDomains');
expect(b).to.have.property('netRevenue', true);
});
});
Expand Down