Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tappx Bid Adapter: update tests, log warinings, and fix consent #6968

Merged
merged 7 commits into from
Jun 8, 2021

Conversation

prebidtappx
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)

Description of change

  • Update log warning messages
  • Update _getHostInfo to improve its tests
  • Add the Pbjs version in the requests
  • Fix: Gdpr consent parameter correction
  • Add more information to the video parameters and set the mimes parameter as mandatory

@ChrisHuie ChrisHuie changed the title tappx Bid Adapter: minor updates and fix consent tappx Bid Adapter: update tests, log warinings, and fix consent Jun 8, 2021
@ChrisHuie ChrisHuie self-requested a review June 8, 2021 14:49
@ChrisHuie ChrisHuie self-assigned this Jun 8, 2021
@ChrisHuie ChrisHuie merged commit 6c07b74 into prebid:master Jun 8, 2021
prebidtappx added a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
…id#6968)

* tappxBidAdapter - Update logWarns messages

* tappxBidAdapter - update _getHostInfo tests

* tappxBidAdapter - Update version and add pbjs version in requests

* tappxBidAdapter - Fix: Add the consent in the correct parameter

* tappxBidAdapter - Make mimes param mandatory for video requests

* tappxBidAdapter - Add more info to video requests

* tappxBidAdapter - replace double quotes with single quotes

Co-authored-by: marc_tappx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants