Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adnuntius Bid Adater: URL changes #7154

Merged
merged 15 commits into from
Jul 8, 2021
Merged

Adnuntius Bid Adater: URL changes #7154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c780e00
Master merge issues
mikael-lundin May 19, 2021
ea14b3a
Adnuntius Bid Adapter: Added tests for gdpr and segments
mikael-lundin May 20, 2021
998caa8
Merge with upstream master
mikael-lundin May 20, 2021
a788d37
Merge remote-tracking branch 'upstream/master'
mikael-lundin May 27, 2021
b7910c6
Moved segments to read from ortb2 instead of a custom value.
mikael-lundin May 27, 2021
24c4230
Merge remote-tracking branch 'upstream/master'
mikael-lundin May 31, 2021
21a1cb1
Changed bidder to read segments from ortb2.
mikael-lundin May 31, 2021
ee72517
fixing lgtm alert
mikael-lundin Jun 3, 2021
0fd6b83
Merge remote-tracking branch 'upstream/master'
mikael-lundin Jun 9, 2021
77f50cc
Merge remote-tracking branch 'upstream/master'
mikael-lundin Jun 14, 2021
90d4a9e
Merge remote-tracking branch 'upstream/master'
mikael-lundin Jun 17, 2021
1585603
Read USI from meta-information in browser.
mikael-lundin Jun 18, 2021
5393064
Merge remote-tracking branch 'upstream/master'
mikael-lundin Jul 8, 2021
6196a58
Changing URL and appending parameters.
mikael-lundin Jul 8, 2021
dd6bec0
Merge branch 'url-changes'
mikael-lundin Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/adnuntiusBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { config } from '../src/config.js';
import { getStorageManager } from '../src/storageManager.js';

const BIDDER_CODE = 'adnuntius';
const ENDPOINT_URL = 'https://delivery.adnuntius.com/i?tzo=';
const ENDPOINT_URL = 'https://ads.adnuntius.delivery/i';
const GVLID = 855;

const checkSegment = function (segment) {
Expand Down Expand Up @@ -33,7 +33,6 @@ const handleMeta = function () {
adnMeta = JSON.parse(storage.getDataFromLocalStorage('adn.metaData'))
}
const meta = (adnMeta !== null) ? adnMeta.reduce((acc, cur) => { return { ...acc, [cur.key]: cur.value } }, {}) : {}
utils.logMessage('STORE', adnMeta, meta)
return meta
}

Expand Down Expand Up @@ -62,6 +61,8 @@ export const spec = {
const tzo = new Date().getTimezoneOffset();
const gdprApplies = utils.deepAccess(bidderRequest, 'gdprConsent.gdprApplies');
const consentString = utils.deepAccess(bidderRequest, 'gdprConsent.consentString');

request.push('tzo=' + tzo)
request.push('format=json')
if (gdprApplies !== undefined) request.push('consentString=' + consentString);
if (segments.length > 0) request.push('segments=' + segments.join(','));
Expand All @@ -87,7 +88,7 @@ export const spec = {
const network = networkKeys[j];
requests.push({
method: 'POST',
url: ENDPOINT_URL + tzo + '&' + request.join('&'),
url: ENDPOINT_URL + '?' + request.join('&'),
data: JSON.stringify(networks[network]),
bid: bidRequests[network]
});
Expand Down
3 changes: 1 addition & 2 deletions test/spec/modules/adnuntiusBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import * as utils from 'src/utils.js';
import { getStorageManager } from 'src/storageManager.js';

describe('adnuntiusBidAdapter', function () {
const URL = 'https://delivery.adnuntius.com/i?tzo=';
const URL = 'https://ads.adnuntius.delivery/i?tzo=';
const GVLID = 855;
const usi = utils.generateUUID()
const meta = [{ key: 'usi', value: usi }]
Expand All @@ -19,7 +19,6 @@ describe('adnuntiusBidAdapter', function () {
});
const tzo = new Date().getTimezoneOffset();
const ENDPOINT_URL = `${URL}${tzo}&format=json&userId=${usi}`;
// const ENDPOINT_URL_SEGMENTS_ = `${URL}${tzo}&format=json`;
const ENDPOINT_URL_SEGMENTS = `${URL}${tzo}&format=json&segments=segment1,segment2,segment3&userId=${usi}`;
const ENDPOINT_URL_CONSENT = `${URL}${tzo}&format=json&consentString=consentString&userId=${usi}`;
const adapter = newBidder(spec);
Expand Down