-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Between Bid Adapter & Airgrid rtd module: fix support for ie11 #7619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
changed the title
betweenBidAdapter: support ie11
between Bid Adapter: support ie11
Oct 22, 2021
2 tasks
patmmccann
changed the title
between Bid Adapter: support ie11
between Bid Adapter & YahooSSP bi adapter: support ie11
Oct 22, 2021
patmmccann
changed the title
between Bid Adapter & YahooSSP bi adapter: support ie11
between Bid Adapter & YahooSSP bid adapter & airgrid rtd module: support ie11
Oct 22, 2021
patmmccann
commented
Oct 22, 2021
@@ -33,7 +33,7 @@ export function attachScriptTagToDOM(rtdConfig) { | |||
edktInitializor.load = function(e) { | |||
var p = e || 'sdk'; | |||
var n = document.createElement('script'); | |||
n.type = 'text/javascript'; | |||
n.type = 'module'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this forces this noncompatible script to not get called on old browsers
patmmccann
changed the title
between Bid Adapter & YahooSSP bid adapter & airgrid rtd module: support ie11
between Bid Adapter & airgrid rtd module & adaptermanager test: support ie11
Oct 22, 2021
ChrisHuie
changed the title
between Bid Adapter & airgrid rtd module & adaptermanager test: support ie11
Between Bid Adapter & Airgrid rtd module: support ie11
Oct 26, 2021
ChrisHuie
changed the title
Between Bid Adapter & Airgrid rtd module: support ie11
Between Bid Adapter & Airgrid rtd module: fix support for ie11
Oct 26, 2021
ChrisHuie
approved these changes
Oct 26, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
…d#7619) * Update betweenBidAdapter.js * Update yahoosspBidAdapter.js * Update adapterManager_spec.js * Update adapterManager_spec.js * Update airgridRtdProvider.js * Update yahoosspBidAdapter.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ie11