Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same ad slot will populate multiple divs #77

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

RobertLippens
Copy link
Contributor

From issue #69

var rightSlot = googletag.defineSlot('12345/slot/name', [[300, 250]], 'div1').addService(googletag.pubads());
var topSlot = googletag.defineSlot('12345/slot/name', [[728,90]], 'div2').addService(googletag.pubads());

Will now populate two different sized ads. The prebid code param in the adUnits array must be set to div1 and div2 for this to work. I did not change setGPTAsyncTargeting and continue to pass the original slot name in so that the targeting behavior does not change.

mkendall07 added a commit that referenced this pull request Oct 22, 2015
Same ad slot will populate multiple divs
@mkendall07 mkendall07 merged commit ad53fd9 into prebid:master Oct 22, 2015
@mkendall07
Copy link
Member

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants