LuponMedia Bid Adapter: user sync endpoint updated

[adxpremium]

Type of change

• [ x] Code style update (formatting, local variables)

[lgtm-com]

This pull request introduces 1 alert when merging e14acda into 00e0bb5 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[musikele]

Hi @adxpremium , code coverage is at 57.22%, that is below 80%, the required minimum to accept this PR.
In order to see code coverage, you can run:

npx gulp test-coverage

followed by

npx gulp view-coverage

[adxpremium]

Hi @adxpremium , code coverage is at 57.22%, that is below 80%, the required minimum to accept this PR. In order to see code coverage, you can run:

npx gulp test-coverage

followed by

npx gulp view-coverage

Hi, we are not sure what code coverage is in this case and what needs to be done on our side to make PR pass the minimum requirements? Could you please explain?

[musikele]

@adxpremium

Hi, we are not sure what code coverage is in this case and what needs to be done on our side to make PR pass the minimum requirements? Could you please explain?

A Prebid rule is that everything that gets merged must have at least 80% code coverage + at least one review.

When we execute unit tests with npx gulp test-coverage, we check that tests are covering at least 80% of total lines of code. If you launch the two commands I wrote above, in your branch, you will be presented with a page with all the code coverage of all modules.

[patmmccann]

can you please remove digitrust references?

[adxpremium]

@patmmccann digitrust is now removed

[patmmccann]

Tyvm

[musikele]

hi there. I still see tests missing for the following functions:

• masSizeOrdering
• setGdprAndPrivacy
• setUserId
• setSiteAndUserData
• setAdserverOrg
• setLiveIntent
• setIdentityLink
• setPubcommon
• mapSizes
• parseSizes

Coverage is still stuck at 56.75% , cannot merge.

[patmmccann]

@adxpremium please see #8372 . Is your use of getLegacyFPD working? It appears not

[lgtm-com]

This pull request introduces 1 alert when merging 1bdc194 into 7a80c65 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[ChrisHuie]

@adxpremium following up on this pr. Looks like there have been more recent additions here but appears to be a current conflict with master? Were you able to update testing for the above functions?

[patmmccann]

@adxpremium review of your adapter cannot proceed until you improve test coverage.

[ChrisHuie]

@adxpremium closing this pr for now. Please feel free to reopen or open an issue if you need help with this adapter update.