Sirdata RTD Module: update and refactor code #8177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running version to be beautified
logInfo removed
with proxistore
with Proxistore
segments to string
merged bid _set
Triplelift + bugs correction
new bidders curation ids
replaced else if with switch
add case where gdpr_applies outside Europe
split user and site data for generic ortb2. new sirdataRtdProvider_spec.js file
Removal of FPD for version prior to 4.29 and bidder "defymedia" and mispell corrections.
IE11 compatibility + minor changes
IE11 Findex error fix
Import findIndex from core-js-pure
Avoid existing settings overriding for ortb2 via setBidderConfig
fixed gdpr detection to switch to cookieless by default
utilize the utils.deepSetValue/mergeDeep/deepAccess functions instead of private _set and hasOwnDeepProperty functions. have a min score to filter categories per bidder.
Use utils.isEmpty
Reduced number of validations and the need to look for ortb2
Encode URL in sent parameters Remove redundant controls Allow sending curation data when no data is available for the publisher
Add Bidders Yahoo SSP, OpenX & Pubmatic
fixed const assign error and loop error coming from Array.prototype overrided by third parties
ChrisHuie
changed the title
|
Apologies for the delay on this, I missed it. I'm so behind on this that a couple userId modules have been added since. Can you make sure the modules/.submodules.json is up to date here? I think it's just missing a couple in userIds. Just in case to make sure this merges correctly. |
|
Hi Brian,
Thanks for your email :) Sure, we’ll find the best way to merge everything correctly tomorrow.
Best
Benoit
Benoît OBERLE
Le 2 mai 2022 à 22:51, Brian Schaaf ***@***.***> a écrit :
Apologies for the delay on this, I missed it.
I'm so behind on this that a couple userId modules have been added since. Can you make sure the modules/.submodules.json is up to date here? I think it's just missing a couple in userIds. Just in case to make sure this merges correctly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
@Rothalack we started again from clean version, please cf PR #8406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Code optimised (removed redondant controls) and new bidders compatibility (Yahoo SSP, Pubmatic and OpenX)