-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vrtcal Bid Adapter: added GDPR, CCPA, COPPA, and timeout passing support #8612
Conversation
@vrtcal-dev can you please also submit an accompanying pr to our docs repo? https://github.com/prebid/prebid.github.io |
Thanks ChrisHuie. We actually already did, but had prematurely submitted before pushing the PBJS adapter updates |
const params = { | ||
prebidJS: 1, | ||
prebidAdUnitCode: bid.adUnitCode, | ||
id: bid.bidId, | ||
tmax: tmax, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should probably be bidderRequest.timeout
. it's equivalent except when the publisher specifies the timeout manually with pbjs.requestBids({timeout: ...})
, in which case this would miss it.
I don't know how much it matters since the correct timeout is enforced by core anyway - it depends on what the backend does with it.
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information