ConnectID: Support new easy-opt out method #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 3, 2022 15:12
|
@slimkrazy can you please add some unit test coverage and pull in recent commits to master. This pr is pretty far behind and looks like acting weird with es-lint in our CircleCi testing 🙏 |
|
@ChrisHuie - I'm not sure what I was thinking by submitting this without additional tests. I've included some now + updated the branch. |
|
Hey @ChrisHuie - may I ask what more I need to do here? Seems the documentation PR was already merged and released: https://docs.prebid.org/dev-docs/modules/userId.html#honoring-privacy-choices |
ChrisHuie
approved these changes
Oct 11, 2022
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* Respect custom opt-out override localstorage key. * Wrap opt-out check in a function. * Rename function * Add unit tests Co-authored-by: slimkrazy <[email protected]>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* Respect custom opt-out override localstorage key. * Wrap opt-out check in a function. * Rename function * Add unit tests Co-authored-by: slimkrazy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
ConnectID is utilised by other client-side libraries outside of Prebid, and Yahoo has introduced a new mechanisms that allow them to provide their users with another way to opt out. This change ensure that our ConnectID userID module respects this.
Other information
Documentation PR: prebid/prebid.github.io#4055