Retailspot Bid Adapter : initial release #9824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ChrisHuie
changed the title
|
@rs-guian can you remove the changes to the packag-lock file from this pr please 🙏 |
|
Hey @rs-guian just quickly popping in, I see this error from your test page. ERROR: Error trying to write ad Id : to the page. Missing adId This is likely the best thing to track down to figure out why you aren't seeing an ad display. When I find more time I'll see what I can find, but thought I'd come drop this here quickly for you! |
guiann
force-pushed
the
retailspot-bidderadapter
branch
from
a8f5bfc to
2ad1241
Compare
|
Thank you Rothalack for your feedback. |
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* add bidder adapter * fix env url * add unit tests * minor: fix bids access in request * add details in bid response * fix unit tests * fix adId undefined case * reset package lock json * handle vastXml as base64 string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
New bidder adapter
contact email of the adapter’s maintainer
[email protected]
link to new documentation on prebid.github.io:
add retailspot documentation prebid.github.io#4490
test parameters for validating bids:
Other information
I'll add unit tests and documentation on prebid.github.io
have a look at the basic test page:
https://retailspot.github.io/RSPlayer-Demo/testPages/prebid/simple.html?pbjs_debug=true