-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for First Party Data #186
Conversation
Has the same logic like as for DFP object.
AdManager v 7.42.2
…into tests/RubiconProject_tests
…into tests/RubiconProject_tests
- default PB request timeout value was moved to PB_Request_Timeout constant - initializing loadSuccesfulException was moved on the beginning because it is possible when fulfill method is called before - minor changes and fixes
…will have a possibility to be shown
-adUnit customKeywords methods were marked as deprecated -added compatibility between adUnit.userKeywords and new global.userKeywords
…into feature/first_party_data
@ppuviarasu Have you had a chance to review this feature ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this PR is for 1st party data… But i see changes made in PBMViewTool.swift
. This has no relevance to the feature specified. PBMViewTool.swift
changes are big & can be separated out as a separate enhancement PR. Please do not mix a feature PR with enhancement changes.
Also this PR has merge conflicts. do resolve the same and request for review |
This reverts commit 84fd96d
…ty_data # Conflicts: # src/PrebidMobile/PrebidMobile.xcodeproj/project.pbxproj # src/PrebidMobile/PrebidMobile/RequestBuilder.swift # src/PrebidMobile/PrebidMobileTests/TargetingTests.swift
@ppuviarasu, I have removed PBMViewTool changes and created issue #225. Merge conflicts were solved |
…ty_data # Conflicts: # src/PrebidMobile/PrebidMobile.xcodeproj/project.pbxproj
…ty_data # Conflicts: # src/PrebidMobile/PrebidMobile/Constants.swift # src/PrebidMobile/PrebidMobile/RequestBuilder.swift
@ppuviarasu, I have fixed conflicts, could you please check it ? |
GitHub issue #181
//ACL block
Access Control List
Targeting
API:Example
Swift:
Objective-C:
[Targeting.shared addBidderToAccessControlList: Prebid.bidderNameRubiconProject];
OpenRTB request:
//data block
2.
global user data
Targeting
API:Example
Swift:
Objective-C:
OpenRTB request:
global context data
Targeting
API:Example
Swift:
Objective-C:
OpenRTB request:
adunit context data
AdUnit
API:Example
Swift:
Objective-C:
OpenRTB request:
global context keywords
Targeting
API:Example
Swift:
Objective-C:
OpenRTB request:
global user keywords
Targeting
API:Example
Swift:
Objective-C:
OpenRTB request:
adunit context keywords
AdUnit
API:Example
Swift:
Objective-C:
OpenRTB request:
Deprecated API
AdUnit. userKeywords
was marked as deprecated, because this parameter createsuser.keywords
object.Since
global user keywords
API has been added in this PR and it brings the functionality to work withuserKeywords
onglobal
level hence I have added a compatibility function to createuser.keywords
object.The logic is: if
globalUserKeywords
is not empty use this one, else useadunitUserKeywords
all_changes_are_included_2.chls.zip