Skip to content

Commit

Permalink
Minor update
Browse files Browse the repository at this point in the history
  • Loading branch information
marki1an committed Jan 30, 2025
1 parent 0320468 commit bb921c4
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,7 @@ class BidderParamsSpec extends BaseSpec {
prebid.bidder.generic = null
prebid.adUnitCode = PBSUtils.randomString
generic = new Generic()
auctionEnvironment = PBSUtils.getRandomEnum(AuctionEnvironment)
auctionEnvironment = PBSUtils.getRandomEnum(AuctionEnvironment, [AuctionEnvironment.SERVER_ORCHESTRATED, AuctionEnvironment.UNKNOWN])
all = PBSUtils.randomNumber
context = new ImpExtContext(data: new ImpExtContextData())
data = new ImpExtContextData(pbAdSlot: PBSUtils.randomString)
Expand Down Expand Up @@ -1025,8 +1025,8 @@ class BidderParamsSpec extends BaseSpec {

def "PBS should send request to bidder when adapters.bidder.aliases.bidder.meta-info.currency-accepted not specified"() {
given: "PBS with adapter configuration"
def pbsConfig = ["adapters.generic.aliases.alias.enabled": "true",
"adapters.generic.aliases.alias.endpoint": "$networkServiceContainer.rootUri/auction".toString(),
def pbsConfig = ["adapters.generic.aliases.alias.enabled" : "true",
"adapters.generic.aliases.alias.endpoint" : "$networkServiceContainer.rootUri/auction".toString(),
"adapters.generic.aliases.alias.meta-info.currency-accepted": ""]
def pbsService = pbsServiceFactory.getService(pbsConfig)

Expand Down Expand Up @@ -1144,8 +1144,8 @@ class BidderParamsSpec extends BaseSpec {

def "PBS should send request to bidder when adapters.bidder.aliases.bidder.meta-info.currency-accepted intersect with requested currency"() {
given: "PBS with adapter configuration"
def pbsConfig = ["adapters.generic.aliases.alias.enabled": "true",
"adapters.generic.aliases.alias.endpoint": "$networkServiceContainer.rootUri/auction".toString(),
def pbsConfig = ["adapters.generic.aliases.alias.enabled" : "true",
"adapters.generic.aliases.alias.endpoint" : "$networkServiceContainer.rootUri/auction".toString(),
"adapters.generic.aliases.alias.meta-info.currency-accepted": "${USD},${EUR}".toString()]
def pbsService = pbsServiceFactory.getService(pbsConfig)

Expand Down Expand Up @@ -1188,8 +1188,8 @@ class BidderParamsSpec extends BaseSpec {

def "PBS shouldn't send request to bidder and emit warning when adapters.bidder.aliases.bidder.meta-info.currency-accepted not intersect with requested currency"() {
given: "PBS with adapter configuration"
def pbsConfig = ["adapters.generic.aliases.alias.enabled": "true",
"adapters.generic.aliases.alias.endpoint": "$networkServiceContainer.rootUri/auction".toString(),
def pbsConfig = ["adapters.generic.aliases.alias.enabled" : "true",
"adapters.generic.aliases.alias.endpoint" : "$networkServiceContainer.rootUri/auction".toString(),
"adapters.generic.aliases.alias.meta-info.currency-accepted": "${JPY},${CHF}".toString()]
def pbsService = pbsServiceFactory.getService(pbsConfig)

Expand Down Expand Up @@ -1281,8 +1281,8 @@ class BidderParamsSpec extends BaseSpec {

def "PBS shouldn't change auction environment in imp.ext.igs when it is present in both imp.ext and imp.ext.igs"() {
given: "Default bid request with populated imp.ext"
def extAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment)
def extIgsAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment)
def extAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment, [SERVER_ORCHESTRATED, UNKNOWN])
def extIgsAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment, [SERVER_ORCHESTRATED, UNKNOWN])
def bidRequest = BidRequest.defaultBidRequest.tap {
imp[0].ext.tap {
auctionEnvironment = extAuctionEnv
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import java.time.Instant
import static org.prebid.server.functional.model.bidder.BidderName.OPENX
import static org.prebid.server.functional.model.bidder.BidderName.OPENX_ALIAS
import static org.prebid.server.functional.model.bidder.BidderName.WILDCARD
import static org.prebid.server.functional.model.request.auction.AuctionEnvironment.*
import static org.prebid.server.functional.model.request.auction.AuctionEnvironment.DEVICE_ORCHESTRATED
import static org.prebid.server.functional.model.request.auction.AuctionEnvironment.NOT_SUPPORTED
import static org.prebid.server.functional.model.request.auction.PaaFormat.IAB
Expand Down Expand Up @@ -546,8 +547,8 @@ class OpenxSpec extends BaseSpec {

def "PBS shouldn't change auction environment in imp.ext.igs and not emit a warning when it is present in both imp.ext and imp.ext.igs"() {
given: "Default bid request with populated imp.ext"
def extAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment)
def extIgsAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment)
def extAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment, [SERVER_ORCHESTRATED, UNKNOWN])
def extIgsAuctionEnv = PBSUtils.getRandomEnum(AuctionEnvironment, [SERVER_ORCHESTRATED, UNKNOWN])
def bidRequest = BidRequest.defaultBidRequest.tap {
imp[0].ext.prebid.bidder.openx = Openx.defaultOpenx
imp[0].ext.prebid.bidder.generic = null
Expand Down

0 comments on commit bb921c4

Please sign in to comment.