-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-imp requests in ttx bidder #1069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DGarbar
suggested changes
Jan 25, 2021
DGarbar
previously approved these changes
Jan 25, 2021
DGarbar
reviewed
Jan 25, 2021
src/main/java/org/prebid/server/proto/openrtb/ext/FlexibleExtension.java
Outdated
Show resolved
Hide resolved
rpanchyk
previously approved these changes
Jan 27, 2021
rpanchyk
approved these changes
Jan 28, 2021
nickluck9
pushed a commit
that referenced
this pull request
Aug 9, 2021
* Add support for multi-imp requests in ttx bidder * Updated position of request ext creating * Fixes after review * Add addProperties instead of constructor creating * Remove changes related to core
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add support for multi-imp requests in ttx bidder * Updated position of request ext creating * Fixes after review * Add addProperties instead of constructor creating * Remove changes related to core
nickluck9
pushed a commit
that referenced
this pull request
Aug 10, 2021
* Add support for multi-imp requests in ttx bidder * Updated position of request ext creating * Fixes after review * Add addProperties instead of constructor creating * Remove changes related to core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from prebid/prebid-server#1609
except
request.ext.ttx.ATTR
field since it is impact core which shouldn't be happen for bidder's modification.