Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Adapter: Alkimi #1841

Merged
merged 30 commits into from
May 16, 2022
Merged

New Adapter: Alkimi #1841

merged 30 commits into from
May 16, 2022

Conversation

pro-nsk
Copy link
Contributor

@pro-nsk pro-nsk commented Apr 26, 2022

No description provided.

mihanikw2g and others added 22 commits December 1, 2021 12:55
@pro-nsk pro-nsk marked this pull request as ready for review April 27, 2022 06:21
@pro-nsk pro-nsk mentioned this pull request Apr 27, 2022
Merged
8 tasks
And1sS
And1sS requested changes Apr 28, 2022
View reviewed changes
src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/bidder/alkimi/AlkimiBidder.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java Outdated Show resolved Hide resolved
src/test/java/org/prebid/server/bidder/alkimi/AlkimiBidderTest.java Outdated Show resolved Hide resolved
@pro-nsk
Copy link
Contributor Author

pro-nsk commented Apr 29, 2022

@And1sS fixed.

@SerhiiNahornyi
Copy link
Collaborator

@pro-nsk You have problems with github action(checkstyle failed)
To be sured, that your code changes will pass our github actions
before push, pls run mvn clean package -f extra

@pro-nsk
Copy link
Contributor Author

pro-nsk commented May 4, 2022

@SerhiiNahornyi Thanks, fixed.

@pro-nsk pro-nsk requested a review from And1sS May 5, 2022 05:16
@pro-nsk pro-nsk requested a review from And1sS May 5, 2022 13:51
@SerhiiNahornyi
Copy link
Collaborator

@pro-nsk Pls consider to fix CI failure

Error:  Failures: 
Error:    AlkimiTest.openrtb2AuctionShouldRespondWithBidsFromAlkimi:34->IntegrationTest.assertJsonEquals:250 ext

@pro-nsk
Copy link
Contributor Author

pro-nsk commented May 16, 2022

@SerhiiNahornyi fixed

SerhiiNahornyi
SerhiiNahornyi approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@SerhiiNahornyi SerhiiNahornyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pro-nsk Thanks for all your changes)

@SerhiiNahornyi SerhiiNahornyi merged commit 30bdabd into prebid:master May 16, 2022
@bretg bretg mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

@And1sS And1sS And1sS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pro-nsk @SerhiiNahornyi @And1sS @mihanikw2g @abalalaev