Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functional tests for aligning TCF and tests for support transmitEids activity controls #2893

Merged
merged 21 commits into from
Feb 29, 2024
Merged

Add functional tests for aligning TCF and tests for support transmitEids activity controls #2893

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
030675c
WIP
osulzhenko Jan 7, 2024
f9402e2
WIP
osulzhenko Jan 8, 2024
90a51ce
Add functional tests for aligning TCF and activity controls and also …
osulzhenko Jan 9, 2024
86355e7
Merge branch 'add-transmit-eids-activity' into functional-tests/Align…
osulzhenko Jan 15, 2024
e433aae
Merge branch 'add-transmit-eids-activity' into functional-tests/Align…
osulzhenko Jan 15, 2024
bbe60b1
Merge branch 'add-transmit-eids-activity' into functional-tests/Align…
osulzhenko Jan 16, 2024
010be34
refactor full enforcement requirments for tcf
osulzhenko Jan 19, 2024
85215c7
refactoring functional tests for tcf
osulzhenko Jan 24, 2024
7e4bd4c
Merge branch 'add-transmit-eids-activity' into functional-tests/Align…
osulzhenko Jan 31, 2024
a205776
update tcf test cases
osulzhenko Feb 2, 2024
f23a2be
minor fix
osulzhenko Feb 5, 2024
6a97a7a
Update TCF functional tests
osulzhenko Feb 13, 2024
673b451
Minor update
osulzhenko Feb 15, 2024
34dcc0a
Merge branch 'add-transmit-eids-activity' into functional-tests/Align…
osulzhenko Feb 27, 2024
7ca04dd
Update after code review
osulzhenko Feb 27, 2024
44e6549
Update after code review
osulzhenko Feb 27, 2024
d73655f
Update after code review
osulzhenko Feb 27, 2024
a8f62cc
Update after code review
osulzhenko Feb 28, 2024
19558d4
Split tcf tests and minor fixes
osulzhenko Feb 29, 2024
4e471ca
minor fix
osulzhenko Feb 29, 2024
e6f19df
minor update
osulzhenko Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/test/groovy/org/prebid/server/functional/model/config/PurposeConfig.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ class PurposeConfig {
PurposeEnforcement enforcePurpose
Boolean enforceVendors
List<String> vendorExceptions
PurposeEid eid
}
14 changes: 14 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/config/PurposeEid.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
package org.prebid.server.functional.model.config

import com.fasterxml.jackson.databind.PropertyNamingStrategies
import com.fasterxml.jackson.databind.annotation.JsonNaming
import groovy.transform.ToString

@ToString(includeNames = true, ignoreNulls = true)
@JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy)
class PurposeEid {

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably missing this configuration prebid/prebid-server#2904.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link for the general page. But config is:

privacy.gdpr.purposes.p4.eid.require_consent: true/false
privacy.gdpr.purposes.p4.eid.exceptions: ["pubcid.org"]

Did I miss something?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this one privacy.gdpr.purposes.p4.eid.activity_transition

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marki1an added, thanks for notes

Boolean requireConsent
List<String> exceptions
Boolean activityTransition
}
23 changes: 23 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/privacy/EnforcementRequirement.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package org.prebid.server.functional.model.privacy

import groovy.transform.ToString
import org.prebid.server.functional.model.bidder.BidderName
import org.prebid.server.functional.model.config.Purpose
import org.prebid.server.functional.model.config.PurposeEnforcement
import org.prebid.server.functional.util.privacy.TcfConsent

@ToString(includeNames = true, ignoreNulls = true)
class EnforcementRequirement {

Purpose purpose
PurposeEnforcement enforcePurpose
Purpose purposeConsent
Boolean enforceVendor
Integer vendorConsentBitField
Integer vendorLegitimateInterestBitField
List<BidderName> vendorExceptions
Purpose purposesLITransparency
List<TcfConsent.RestrictionType> restrictionType
Integer vendorIdGvl
Integer vendorListVersion
}
2 changes: 1 addition & 1 deletion src/test/groovy/org/prebid/server/functional/model/request/auction/ActivityType.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ enum ActivityType {
TRANSMIT_UFPD("transmitUfpd"),
TRANSMIT_PRECISE_GEO("transmitPreciseGeo"),
TRANSMIT_TID("transmitTid"),
TRANSMIT_EIDS("transmitEids"),
TRANSMIT_EIDS("transmitEids")

@JsonValue
final String value
Expand Down
4 changes: 4 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/request/auction/AllowActivities.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package org.prebid.server.functional.model.request.auction

import groovy.transform.ToString

import static org.prebid.server.functional.model.request.auction.ActivityType.TRANSMIT_EIDS
import static org.prebid.server.functional.model.request.auction.ActivityType.TRANSMIT_PRECISE_GEO
import static org.prebid.server.functional.model.request.auction.ActivityType.TRANSMIT_TID
import static org.prebid.server.functional.model.request.auction.ActivityType.TRANSMIT_UFPD
Expand All @@ -18,6 +19,7 @@ class AllowActivities {
Activity enrichUfpd
Activity reportAnalytics
Activity transmitUfpd
Activity transmitEids
Activity transmitPreciseGeo
Activity transmitTid

Expand All @@ -30,6 +32,8 @@ class AllowActivities {
return fetchBids = activity
case ENRICH_UFPD:
return enrichUfpd = activity
case TRANSMIT_EIDS:
return transmitEids = activity
case REPORT_ANALYTICS:
return reportAnalytics = activity
case TRANSMIT_UFPD:
Expand Down
2 changes: 2 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/request/auction/Eid.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package org.prebid.server.functional.model.request.auction

import groovy.transform.EqualsAndHashCode
import groovy.transform.ToString
import org.prebid.server.functional.util.PBSUtils

@ToString(includeNames = true, ignoreNulls = true)
@EqualsAndHashCode
class Eid {

String source
Expand Down
2 changes: 2 additions & 0 deletions src/test/groovy/org/prebid/server/functional/model/request/auction/Uid.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package org.prebid.server.functional.model.request.auction

import groovy.transform.EqualsAndHashCode
import groovy.transform.ToString
import org.prebid.server.functional.util.PBSUtils

@ToString(includeNames = true, ignoreNulls = true)
@EqualsAndHashCode
class Uid {

String id
Expand Down
5 changes: 5 additions & 0 deletions src/test/groovy/org/prebid/server/functional/testcontainers/scaffolding/VendorList.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ class VendorList extends NetworkScaffolding {
request().withPath(VENDOR_LIST_ENDPOINT)
}

@Override
void reset() {
TcfPolicyVersion.values().each { version -> super.reset("/v${version.vendorListVersion}/vendor-list.json") }
}

void setResponse(TcfPolicyVersion tcfPolicyVersion = TCF_POLICY_V2,
Map<Integer, Vendor> vendors = [(GENERIC_VENDOR_ID): Vendor.getDefaultVendor(GENERIC_VENDOR_ID)]) {
def prepareEndpoint = endpoint.replace("{TCF_POLICY}", "v" + tcfPolicyVersion.vendorListVersion)
Expand Down
4 changes: 2 additions & 2 deletions src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ class AuctionSpec extends BaseSpec {

then: "Bidder request shouldn't contain buyeruid from the user.ext.prebid.buyeruids"
def bidderRequest = bidder.getBidderRequest(bidRequest.id)
assert !bidderRequest.user
assert !bidderRequest.user.ext
}

def "PBS should populate buyeruid from uids cookie when buyeruids with appropriate bidder but without value present in request"() {
Expand Down Expand Up @@ -213,7 +213,7 @@ class AuctionSpec extends BaseSpec {

then: "Bidder request shouldn't contain buyeruid from the uids cookie"
def bidderRequest = bidder.getBidderRequest(bidRequest.id)
assert !bidderRequest.user
assert !bidderRequest.user.buyeruid
}

def "PBS should take precedence buyeruids whenever present valid uid cookie"() {
Expand Down
2 changes: 0 additions & 2 deletions src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import org.prebid.server.functional.model.db.Account
import org.prebid.server.functional.model.db.StoredImp
import org.prebid.server.functional.model.db.StoredRequest
import org.prebid.server.functional.model.request.amp.AmpRequest
import org.prebid.server.functional.model.request.auction.Asset
import org.prebid.server.functional.model.request.auction.Banner
import org.prebid.server.functional.model.request.auction.BidRequest
import org.prebid.server.functional.model.request.auction.Device
Expand All @@ -24,7 +23,6 @@ import org.prebid.server.functional.model.response.auction.BidResponse
import org.prebid.server.functional.model.response.auction.ErrorType
import org.prebid.server.functional.util.PBSUtils
import org.prebid.server.functional.util.privacy.CcpaConsent
import spock.lang.IgnoreRest

import static org.prebid.server.functional.model.bidder.BidderName.APPNEXUS
import static org.prebid.server.functional.model.bidder.BidderName.GENERIC
Expand Down
2 changes: 0 additions & 2 deletions src/test/groovy/org/prebid/server/functional/tests/TargetingSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ import org.prebid.server.functional.model.response.auction.Bid
import org.prebid.server.functional.model.response.auction.BidResponse
import org.prebid.server.functional.service.PrebidServerService
import org.prebid.server.functional.util.PBSUtils
import spock.lang.IgnoreRest
import spock.lang.RepeatUntilFailure

import java.math.RoundingMode

Expand Down
1 change: 0 additions & 1 deletion src/test/groovy/org/prebid/server/functional/tests/privacy/GppSyncUserActivitiesSpec.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1385,7 +1385,6 @@ class GppSyncUserActivitiesSpec extends PrivacyBaseSpec {
assert response.responseBody
}


def "PBS setuid call when privacy regulation don't match custom requirement should respond with required UIDs cookies"() {
given: "Cookie sync SetuidRequest with accountId"
def accountId = PBSUtils.randomNumber as String
Expand Down
Loading