Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Transition PAAPI parameters #3670

Merged
merged 27 commits into from
Jan 28, 2025
Merged

Core: Transition PAAPI parameters #3670

merged 27 commits into from
Jan 28, 2025
+1,847 −410

Conversation

And1sS
Copy link
Member

@And1sS And1sS commented Jan 9, 2025

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

prebid/prebid-server#3536

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

Unit tests + functional tests

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

AntoxaAntoxic
AntoxaAntoxic reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@AntoxaAntoxic AntoxaAntoxic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

src/main/java/org/prebid/server/auction/BidResponseCreator.java Outdated Show resolved Hide resolved
src/main/java/org/prebid/server/auction/model/BidRejectionTracker.java Show resolved Hide resolved
oronno
oronno suggested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@oronno oronno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this change without braking existing contract?

src/main/java/org/prebid/server/bidder/ix/IxBidder.java Show resolved Hide resolved
@marki1an
Test: Transition PAAPI parameters (#3634)
7ea648e 
* Add functional tests for Transition PAAPI parameters to updated IAB conventions.
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Jan 27, 2025
View reviewed changes
CTMBNara
CTMBNara previously approved these changes Jan 27, 2025
View reviewed changes
@osulzhenko
Merge branch 'refs/heads/master' into feature/paa
77df115 
# Conflicts:
#	src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
@osulzhenko osulzhenko dismissed stale reviews from CTMBNara and AntoxaAntoxic via 77df115 January 28, 2025 14:11
@CTMBNara CTMBNara merged commit 02ab379 into master Jan 28, 2025
6 of 8 checks passed
@CTMBNara CTMBNara deleted the feature/paa branch January 28, 2025 16:09
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oronno oronno oronno requested changes

@CTMBNara CTMBNara CTMBNara approved these changes

@AntoxaAntoxic AntoxaAntoxic AntoxaAntoxic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@And1sS @oronno @CTMBNara @AntoxaAntoxic @marki1an @osulzhenko