bid.mtype takes precedence to bid.ext.prebid.type

prebid · Mar 6, 2023 · 0214cba · 0214cba
1 parent c67d486
commit 0214cba
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 3 deletions.
diff --git a/exchange/exchange.go b/exchange/exchange.go
@@ -1314,9 +1314,16 @@ func buildStoredAuctionResponse(storedAuctionResponses map[string]json.RawMessag
 			//set imp id from request
 			for i := range seat.Bid {
 				seat.Bid[i].ImpID = impId
-				bidType, err := getMediaTypeForBid(seat.Bid[i])
-				if err != nil {
-					return nil, nil, nil, err
+				mType := seat.Bid[i].MType
+				var bidType openrtb_ext.BidType
+				if mType != 0 {
+					bidType = openrtb_ext.BidTypes()[mType-1]
+				} else {
+					var err error
+					bidType, err = getMediaTypeForBid(seat.Bid[i])
+					if err != nil {
+						return nil, nil, nil, err
+					}
 				}
 				bidsToAdd = append(bidsToAdd, &entities.PbsOrtbBid{Bid: &seat.Bid[i], BidType: bidType})
 			}

diff --git a/exchange/exchange_test.go b/exchange/exchange_test.go
@@ -4125,6 +4125,27 @@ func TestBuildStoredAuctionResponses(t *testing.T) {
 				},
 			},
 		},
+		{
+			desc: "Single imp with single stored response bid with bid.mtype",
+			in: testIn{
+				StoredAuctionResponses: map[string]json.RawMessage{
+					"impression-id": json.RawMessage(`[{"bid": [{"id": "bid_id", "mtype": 2, "ext": {"prebid": {"type": "native"}}}],"seat": "appnexus"}]`),
+				},
+			},
+			expected: testResults{
+				adapterBids: map[openrtb_ext.BidderName]*entities.PbsOrtbSeatBid{
+					openrtb_ext.BidderName("appnexus"): {
+						Bids: []*entities.PbsOrtbBid{
+							{
+								Bid:     &openrtb2.Bid{ID: "bid_id", ImpID: "impression-id", MType: 2, Ext: []byte(`{"prebid": {"type": "native"}}`)},
+								BidType: openrtb_ext.BidTypeVideo,
+							},
+						},
+					},
+				},
+				liveAdapters: []openrtb_ext.BidderName{openrtb_ext.BidderName("appnexus")},
+			},
+		},
 	}
 	for _, test := range testCases {