Finalize PR (#8)

[#164911891]

Co-authored-by: Josh Becker <[email protected]>

adapters/sharethrough/params_test.go

@@ -0,0 +1,58 @@
+package sharethrough
+
+import (
+	"encoding/json"
+	"testing"
+
+	"github.com/prebid/prebid-server/openrtb_ext"
+)
+
+func TestValidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	if err != nil {
+		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+	}
+
+	for _, validParam := range validParams {
+		if err := validator.Validate(openrtb_ext.BidderSharethrough, json.RawMessage(validParam)); err != nil {
+			t.Errorf("Schema rejected Sharethrough params: %s", validParam)
+		}
+	}
+}
+
+func TestInvalidParams(t *testing.T) {
+	validator, err := openrtb_ext.NewBidderParamsValidator("../../static/bidder-params")
+	if err != nil {
+		t.Fatalf("Failed to fetch the json-schemas. %v", err)
+	}
+
+	for _, invalidParam := range invalidParams {
+		if err := validator.Validate(openrtb_ext.BidderSharethrough, json.RawMessage(invalidParam)); err == nil {
+			t.Errorf("Schema allowed unexpected params: %s", invalidParam)
+		}
+	}
+}
+
+var validParams = []string{
+	`{"pkey": "123"}`,
+	`{"pkey": "123", "iframe": true}`,
+	`{"pkey": "abc", "iframe": false}`,
+	`{"pkey": "abc123", "iframe": true, "iframeSize": [20, 20]}`,
+}
+
+var invalidParams = []string{
+	``,
+	`null`,
+	`true`,
+	`5`,
+	`4.2`,
+	`[]`,
+	`{}`,
+	`{"pkey": 123}`,
+	`{"iframe": 123}`,
+	`{"iframeSize": [20, 20]}`,
+	`{"pkey": 123, "iframe": 123}`,
+	`{"pkey": 123, "iframe": true, "iframeSize": [20]}`,
+	`{"pkey": 123, "iframe": true, "iframeSize": []}`,
+	`{"pkey": 123, "iframe": true, "iframeSize": 123}`,
+}

adapters/sharethrough/sharethroughtest/params/race/banner.json

@@ -0,0 +1,5 @@
+{
+  "pkey": "abc123",
+  "iframe": true,
+  "iframeSize": [50, 50]
+}

adapters/sharethrough/sharethroughtest/params/race/native.json

@@ -0,0 +1,5 @@
+{
+  "pkey": "abc123",
+  "iframe": true,
+  "iframeSize": [50, 50]
+}

config/config.go

@@ -557,7 +557,7 @@ func SetupViper(v *viper.Viper, filename string) {
 	v.SetDefault("adapters.rhythmone.endpoint", "http://tag.1rx.io/rmp")
 	v.SetDefault("adapters.gumgum.endpoint", "https://g2.gumgum.com/providers/prbds2s/bid")
 	v.SetDefault("adapters.grid.endpoint", "http://grid.bidswitch.net/sp_bid?sp=prebid")
-	v.SetDefault("adapters.sharethrough.endpoint", "http://localhost:8001/butler")
+	v.SetDefault("adapters.sharethrough.endpoint", "http://btlr.sharethrough.com/FGMrCMMc/v1")
 	v.SetDefault("adapters.sonobi.endpoint", "https://apex.go.sonobi.com/prebid?partnerid=71d9d3d8af")
 	v.SetDefault("adapters.yieldmo.endpoint", "http://ads.yieldmo.com/exchange/prebid-server")
 	v.SetDefault("adapters.gamoshi.endpoint", "https://rtb.gamoshi.io")

static/bidder-info/sharethrough.yaml

@@ -4,6 +4,8 @@ capabilities:
   app:
     mediaTypes:
       - native
+      - banner
   site:
     mediaTypes:
       - native
+      - banner