Fix TCF1 Fetcher Fallback #1438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Aug 12, 2020
| @@ -158,7 +158,7 @@ func newVendorListCache(fallbackVL api.VendorList) (save func(id uint16, list ap | |||
| if ok { | |||
| return list.(vendorlist.VendorList) | |||
| } | |||
| return fallbackVL | |||
| return nil | |||
There was a problem hiding this comment.
This method needs to return nil in order to attempt a url lazy loading fetch. If we return fallbackVL here, it effectively disables lazy loading.
guscarreon
reviewed
Aug 12, 2020
gdpr/vendorlist-fetching_test.go
Outdated
| @@ -196,15 +196,15 @@ func TestDefaultVendorListPassthrough(t *testing.T) { | |||
| fetcher := newVendorListFetcher(context.Background(), testcfg, server.Client(), testURLMaker(server), 1) | |||
| list, err := fetcher(context.Background(), 2) | |||
| assert.NoError(t, err, "Error with fetching existing vendorlist: %v", err) | |||
| assert.Equal(t, uint16(2), list.Version(), "Expected to fetch mock list version 2, got version %d", list.Version()) | |||
| assert.Equal(t, uint16(2), list.Version(), "Expected to fetch mock list version 1, got version %d", list.Version()) | |||
There was a problem hiding this comment.
Shouldn't the expected value be uint16(1) instead?
There was a problem hiding this comment.
No,. It should be version 2. I forgot to revert my change to the comment.
SyntaxNode
commented
Aug 12, 2020
| @@ -184,7 +184,7 @@ func TestDefaultVendorListPassthrough(t *testing.T) { | |||
| purposes: []int{2}, | |||
| }, | |||
| }) | |||
| server := httptest.NewServer(http.HandlerFunc(mockServer(2, map[int]string{ | |||
There was a problem hiding this comment.
Both lists were originally preloaded and always pulled from cache. If we change the latest version from 2 to 1, it no longer preloads version 2 and attempts a lazy load. This exposed the bug.
hhhjort
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in 0.124.0 where the TCF1 vendor list fetcher will never attempt lazy loading.