Pass Through First Party Context Data #1479
+769
−23
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| { | ||
| "description": "xxx", | ||
|
|
||
| "requestPayload": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "appnexus": { | ||
| "placementId": 12883451 | ||
| }, | ||
| "context": { | ||
|
There was a problem hiding this comment. This throws a validation exception currently. |
||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| { | ||
| "incomingRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "appnexus": { | ||
| "placementId": 1 | ||
| }, | ||
| "rubicon": { | ||
| "accountId": 1, | ||
| "siteId": 2, | ||
| "zoneId": 3 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| } | ||
| }, | ||
| "outgoingRequests": { | ||
| "appnexus": { | ||
| "expectRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "placementId": 1 | ||
| }, | ||
| "context": { | ||
|
There was a problem hiding this comment. This is considered a bidder today and causes all sorts of panics currently (when the validation now allows it). |
||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| }, | ||
| "bidAdjustment": 1.0 | ||
| }, | ||
| "mockResponse": { | ||
| "pbsSeatBid": { | ||
| "pbsBids": [{ | ||
| "ortbBid": { | ||
| "id": "apn-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.3, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-1" | ||
| }, | ||
| "bidType": "banner" | ||
| }] | ||
| } | ||
| } | ||
| }, | ||
| "rubicon": { | ||
| "expectRequest": { | ||
| "ortbRequest": { | ||
| "id": "some-request-id", | ||
| "site": { | ||
| "page": "test.somepage.com" | ||
| }, | ||
| "imp": [{ | ||
| "id": "some-imp-id", | ||
| "banner": { | ||
| "format": [{ | ||
| "w": 600, | ||
| "h": 500 | ||
| }, { | ||
| "w": 300, | ||
| "h": 600 | ||
| }] | ||
| }, | ||
| "ext": { | ||
| "bidder": { | ||
| "accountId": 1, | ||
| "siteId": 2, | ||
| "zoneId": 3 | ||
| }, | ||
| "context": { | ||
| "data": { | ||
| "keywords": "prebid server example" | ||
| } | ||
| } | ||
| } | ||
| }] | ||
| }, | ||
| "bidAdjustment": 1.0 | ||
| }, | ||
| "mockResponse": { | ||
| "pbsSeatBid": { | ||
| "pbsBids": [{ | ||
| "ortbBid": { | ||
| "id": "rubi-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.4, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-2" | ||
| }, | ||
| "bidType": "banner" | ||
| }] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "response": { | ||
| "bids": { | ||
| "id": "some-request-id", | ||
| "seatbid": [{ | ||
| "seat": "appnexus", | ||
| "bid": [{ | ||
| "id": "apn-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.3, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-1", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| } | ||
| } | ||
| }] | ||
| }, { | ||
| "seat": "rubicon", | ||
| "bid": [{ | ||
| "id": "rubi-bid", | ||
| "impid": "some-imp-id", | ||
| "price": 0.4, | ||
| "w": 200, | ||
| "h": 500, | ||
| "crid": "creative-2", | ||
| "ext": { | ||
| "prebid": { | ||
| "type": "banner" | ||
| } | ||
| } | ||
| }] | ||
| }] | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to talk about this behavior. It makes no sense to me and looks like a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about this more and now consider it a bug. As a follow-up PR, I'd like to make the validate method only actually validate and move the disabled bidder logic to
exchange.go, if it's not already there.