-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emxd 3336 add app video ctv #1529
Emxd 3336 add app video ctv #1529
Conversation
Juts following up here, the checks seem to be failing due to an independent/non-related part of the package
EMX Digital adapter looks to be okay and has > 90% testing coverage |
I'll take a look at that test failure since I recently worked on that test. |
@bsardo looks like all the checks are passing now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a few minor comments. Please review the docs for this adapter to check if any changes are needed: https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/emx_digital.md
@SyntaxNode Updated code based on feedback and discussion with team. Ready for another round |
Is the intent to support the |
@SyntaxNode No, we are not looking to support long form video at this time, just the vanilla video integrations |
Gotcha. Sometimes CTV = Long Form Video, so I wanted to ask. Thank you. |
Thanks @hhhjort for merging this in - will there be an official release coming out in the coming days that we can use to message to Publishers for what version of Prebid S2S supports this new functionality? |
We don't have a set in stone schedule for releases, but there is likely to be a release tomorrow. If not then there should be a release in the middle of next week. The version will be 0.134.0 of course. |
Adding video support to EMX Digital adapter