Add account CCPA enabled and per-request-type enabled flags #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Manually verified for web, app and amp |
SyntaxNode
reviewed
Nov 16, 2020
config/accounts.go
Outdated
| } | ||
|
|
||
| // AccountCCPAIntegration indicates whether CCPA is enabled for each request type | ||
| type AccountCCPAIntegration struct { |
There was a problem hiding this comment.
Eh. I think AccountCCPA makes sense, but I wouldn't mind having just one unified AccountIntegration, or some such. The only downside is it becomes harder to add a CCPA or GDPR specific value.. but we could always split the types then.
hhhjort
previously approved these changes
Nov 17, 2020
SyntaxNode
reviewed
Nov 18, 2020
config/accounts.go
Outdated
| if integrationEnabled := a.IntegrationEnabled.GetByIntegrationType(integrationType); integrationEnabled != nil { | ||
| return integrationEnabled | ||
| } | ||
| if a.Enabled != nil { |
There was a problem hiding this comment.
Nitpick: You can just return a.Enabled here. Does't matter if it's nil or not. Comment is great and accurate.
config/accounts.go
Outdated
|
|
||
| if integrationEnabled != nil { | ||
| if integrationEnabled := a.IntegrationEnabled.GetByIntegrationType(integrationType); integrationEnabled != nil { | ||
| return integrationEnabled | ||
| } | ||
| if a.Enabled != nil { |
There was a problem hiding this comment.
Same nitpick here. Sorry. Seems I missed this the first time around.
SyntaxNode
approved these changes
Nov 18, 2020
hhhjort
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what we are doing for GDPR, as described in issue #1323 and PR #1564, this adds account-level CCPA configuration.
The order of precedence for determining whether CCPA is enabled is the same as for GDPR: