-
Notifications
You must be signed in to change notification settings - Fork 766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stored response fetcher (with new param) #2062
Conversation
Initial working implementation is ready for review.
|
|
@@ -86,7 +86,8 @@ func NewAmpEndpoint( | |||
bidderMap, | |||
nil, | |||
nil, | |||
ipValidator}).AmpAuction), nil | |||
ipValidator, | |||
empty_fetcher.EmptyFetcher{}}).AmpAuction), nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using an empty fetcher? We should be able to use stored responses on the AMP endpoint I would imagine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this yet. Do we need to support stored response functionality in amp endpoint?
@@ -109,6 +111,7 @@ type endpointDeps struct { | |||
cache prebid_cache_client.Client | |||
debugLogRegexp *regexp.Regexp | |||
privateNetworkIPValidator iputil.IPValidator | |||
storedRespFetcher stored_requests.Fetcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the code that checks for the stored response signal, and then bypasses sending a request to the bidder and just providing the stored response to the flow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is only about stored response fetcher.
We decided to have smaller PRs that are easy to review rather than having big and complicated PRs.
I understand this fetcher is not connected to anything and has no usages.
I'll add actual code related to stored responses in another PR.
Closing this in favor of #2099. Will reopen if needed. |
Stored response fetcher