AdsCert signer metrics #2351
Merged
AdsCert signer metrics #2351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhjort
reviewed
Aug 15, 2022
| signatureMessage, err := adsCertSigner.Sign(reqData[i].Uri, reqData[i].Body) | ||
| bidder.me.RecordAdsCertSignTime(time.Since(startSignRequestTime)) |
There was a problem hiding this comment.
Do we expect that the time taken to generate a signature to be significant to warrant tracking as a metric?
There was a problem hiding this comment.
When we enable this feature it can help to show if this feature can be a potential bottleneck in request handling. It can be especially valuable when PBS uses remote signatory service.
@SyntaxNode please confirm
There was a problem hiding this comment.
Only question in my mind at this point is should it always be active, or should we have a config option to turn at least the timing off? The success/failure metric should only take 2 datapoints per time step, but the timing will eat up ~20 datapoints per time step.
hhhjort
approved these changes
Aug 17, 2022
mansinahar
approved these changes
Aug 18, 2022
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
pm-aadit-patil
pushed a commit
to PubMatic-OpenWrap/prebid-server
that referenced
this pull request
Sep 22, 2022
jorgeluisrocha
pushed a commit
to jwplayer/prebid-server
that referenced
this pull request
Sep 28, 2022
shunj-nb
pushed a commit
to ParticleMedia/prebid-server
that referenced
this pull request
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New metrics are added to track AdsCert signing:
RecordAdsCertReq- record requests with AdsCert header, tracks number of successful and failed requests.RecordAdsCertSignTime- time to sign AdsCert requestLocal test with Prometheus passed, all metrics are correctly displayed in Prometheus data