Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubicon: shared memory issue fix #2704

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Rubicon: shared memory issue fix #2704

merged 2 commits into from
Apr 18, 2023

Conversation

VeronikaSolovei9
Copy link
Contributor

No description provided.

guscarreon
guscarreon approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo
Copy link
Collaborator

bsardo commented Apr 17, 2023 •
edited
Loading

@SerhiiNahornyi @CTMBNara this PR fixes a shared memory issue that involves the 2.5 to 2.6 up convert utility function. The tests did not catch the problem because the mock request in the JSON test 25-26-transition-period.json had the regs, schain and user information in the 2.6 location already so the conversion logic had no effect. By moving this information to the 2.5 location in the test, we were able to reproduce the error through automated tests and then verify the fix.
We aren't changing any behavior here. We're planning to merge this tomorrow if you'd like to give it a look and provide any feedback. Thanks!

@SerhiiNahornyi
Copy link
Contributor

Nice catch!

@bsardo bsardo merged commit 46eaf1b into master Apr 18, 2023
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Apr 18, 2023
Closed
blueseasx pushed a commit to blueseasx/prebid-server that referenced this pull request Jun 2, 2023
@VeronikaSolovei9
Rubicon: shared memory issue fix (prebid#2704)
0cd4fe0
@SyntaxNode SyntaxNode deleted the rubicon_fix branch August 28, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsardo bsardo bsardo approved these changes

@guscarreon guscarreon guscarreon approved these changes

@SerhiiNahornyi SerhiiNahornyi SerhiiNahornyi approved these changes

@SyntaxNode SyntaxNode Awaiting requested review from SyntaxNode

Assignees

@bsardo bsardo

@guscarreon guscarreon

@SerhiiNahornyi SerhiiNahornyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@VeronikaSolovei9 @bsardo @SerhiiNahornyi @guscarreon