Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Richaudience: Shared memory fix #2710

Merged
merged 5 commits into from
May 1, 2023
Merged

Richaudience: Shared memory fix #2710

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a4c6d2b
Shared memory fix
VeronikaSolovei9 Apr 20, 2023
ebc4d36
Minor reference usage fix
VeronikaSolovei9 Apr 20, 2023
d903552
Removed empty lines
VeronikaSolovei9 Apr 21, 2023
62e9b3e
Code review feedback addressed
VeronikaSolovei9 Apr 24, 2023
345341b
Added nil check for req.device
VeronikaSolovei9 May 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions adapters/richaudience/richaudience.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,16 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapte
}

if request.App != nil {
appCopy := *request.App
request.App = &appCopy

request.App.Keywords = "tagid=" + imp.TagID
}

if request.Site != nil {
siteCopy := *request.Site
request.Site = &siteCopy

request.Site.Keywords = "tagid=" + imp.TagID
}

Expand All @@ -65,6 +71,9 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, requestInfo *adapte
}

if raiExt.Test {
deviceCopy := *request.Device
request.Device = &deviceCopy

request.Device.IP = "11.222.33.44"
request.Test = int8(1)
}
Expand Down
6 changes: 3 additions & 3 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
},
"bidfloor": 1e-05,
"bidfloorcur": "USD",
"tagid": "testTag",
"ext": {
"bidder": {
"pid": "OsNsyeF68q",
Expand All @@ -24,7 +25,6 @@
],
"app": {
"id": "12345678",
"keywords": "tagid=",
"name": "Richaudience TV",
"bundle": "R12345678901011",
"publisher": {
Expand All @@ -41,7 +41,7 @@
}
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ifa": "zxcjbzxmc-zxcbmz-zxbcz-zxczx"
},
"user": {
Expand Down Expand Up @@ -86,7 +86,7 @@
],
"app": {
"id": "12345678",
"keywords": "tagid=",
"keywords": "tagid=testTag",
"name": "Richaudience TV",
"bundle": "R12345678901011",
"publisher": {
Expand Down
6 changes: 3 additions & 3 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-defaultCurrency.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
]
},
"bidfloor": 1e-05,
"tagid": "testTag",
"ext": {
"bidder": {
"pid": "OsNsyeF68q",
Expand All @@ -24,12 +25,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down Expand Up @@ -80,7 +80,7 @@
}
],
"site": {
"keywords": "tagid=",
"keywords": "tagid=testTag",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
Expand Down
6 changes: 3 additions & 3 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-deviceConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
},
"bidfloor": 1e-05,
"bidfloorcur": "USD",
"tagid": "testTag",
"ext": {
"bidder": {
"pid": "OsNsyeF68q",
Expand All @@ -23,14 +24,13 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"dnt": 1,
"lmt": 1,
"ip": "11.222.33.44"
"ip": "10.20.30.40"
},
"user": {
"buyeruid": "189f4055-78a3-46eb-b7fd-0915a1a43bd2a",
Expand Down Expand Up @@ -73,7 +73,7 @@
}
],
"site": {
"keywords": "tagid=",
"keywords": "tagid=testTag",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-extUser.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-floorPrice.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-iPv6.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ipv6": "2607:fb90:f27:4512:d800:cb23:a603:e245",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-nosecure.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "http://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-setCurrency.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner-sitePage.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down
3 changes: 1 addition & 2 deletions adapters/richaudience/richaudiencetest/exemplary/single-video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,11 @@
}
],
"site": {
"keywords": "tagid=",
"domain": "bridge.richmediastudio.com",
"page": "https://bridge.richmediastudio.com//ab083674fb8200b877a6983126e4477d/PrebidServer/indexRa.html?pbjs_debug=true"
},
"device": {
"ip": "11.222.33.44",
"ip": "10.20.30.40",
"ua": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.114 Safari/537.36"
},
"user": {
Expand Down