Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go-vet errors related to privacy/enforcer #2978

Closed
wants to merge 1 commit into from

Conversation

onkarvhanumante
Copy link
Contributor

@onkarvhanumante onkarvhanumante commented Jul 27, 2023

  • Activities framework #2844 made some changes to privacy/enforcer. This feature is in development so some code paths were intentionally made unreachable.
  • However, this resulted in following go vet error:
    % (go vet ./... 2>&1) | grep -v -E "composite literal uses unkeyed fields"
     # github.com/prebid/prebid-server/adapters/adoppler
     # github.com/prebid/prebid-server/amp
     # github.com/prebid/prebid-server/endpoints/info
     # github.com/prebid/prebid-server/endpoints/events
     # github.com/prebid/prebid-server/endpoints
     # github.com/prebid/prebid-server/privacy
     privacy/enforcer.go:41:2: unreachable code
    
  • The go vet check from PR tests is broken. So above error was never reported on PR. Refer fix errors reported by go vet  #2954 for more details.
  • Plan is to fix go vet check. But before implementing fix, let's address any previously uncaught errors or warnings.

@onkarvhanumante onkarvhanumante changed the title fix go-vet warning related to privacy/enforcer fix go-vet errors related to privacy/enforcer Jul 27, 2023
@VeronikaSolovei9
Copy link
Contributor

VeronikaSolovei9 commented Jul 27, 2023

Onkar, thank you for this PR!
May you please re-check the latest master to make sure this issue is not reproducible after we merged FPD/GEO PR: #2906

@onkarvhanumante
Copy link
Contributor Author

Onkar, thank you for this PR! May you please re-check the latest master to make sure this issue is not reproducible after we merged FPD/GEO PR: #2906

Ran checks on updated master. #2906 fixes the go vet error of privacy/enforcer. Changes from this PR are no longer needed.

@onkarvhanumante onkarvhanumante deleted the fix-go-vet-enforcer-warning branch July 28, 2023 07:42
@VeronikaSolovei9
Copy link
Contributor

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants