Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sovrn: Adapter update user sync urls for gpp #3061

Merged

Conversation

ikagotso
Copy link
Contributor

No description provided.

@@ -17,6 +17,6 @@ userSync:
url: "https://ap.lijit.com/pixel?redir={{.RedirectURL}}"
userMacro: "$UID"
iframe:
url: "https://ap.lijit.com/beacon/prebid-server/?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&url={{.RedirectURL}}"
url: "https://ap.lijit.com/beacon/prebid-server/?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&url={{.RedirectURL}}"
redirectUrl: "{{.ExternalURL}}/setuid?bidder={{.SyncerKey}}&f={{.SyncType}}&uid={{.UserMacro}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value of redirectUrl is {{.ExternalURL}}/setuid?bidder={{.SyncerKey}}&gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&f={{.SyncType}}&uid={{.UserMacro}}

Any reason for not using the default value?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @gargcreation1992 in that I don't see a need to override the redirectUrl.

The Redirect URL is for calling back to Prebid Server. Overriding this value to exclude privacy policies may prevent Prebid Server from adhering to regulations. It may be appropriate for host companies to override this field for specific cases or for adapters to cautiously override for highly custom uid scenarios.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the default redurectUrl we get the same consent info in the url query parameter value and dedicated consent parameters gdpr, gdpr_consent, gpp, gpp_sid. So we changed the config to address this duplication. But now I think you're right. We'll handle this on our side and keep configs as close to default as possible.

…handle the duplication of the consent data in Raptor. (EX-4761 will address this issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants