Conversant: Make requests in USD #3611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
| //Backend needs USD or it will reject the request | ||
| if cnvrRequest.Cur != nil && len(cnvrRequest.Cur) > 0 && cnvrRequest.Cur[0] != "USD" { | ||
| cnvrRequest.Cur = []string{"USD"} | ||
| } |
There was a problem hiding this comment.
Please add the json test cases for this change.
There was a problem hiding this comment.
I have added this to one of the test cases
| imp.BidFloorCur = "USD" | ||
| imp.BidFloor = floor | ||
| } | ||
| } |
There was a problem hiding this comment.
Please add the json test case for this change.
There was a problem hiding this comment.
I have added this to one of the test cases
SyntaxNode
reviewed
Apr 9, 2024
adapters/conversant/conversant.go
Outdated
| @@ -18,6 +19,11 @@ type ConversantAdapter struct { | |||
| } | |||
|
|
|||
| func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) { | |||
| cnvrRequest := *request | |||
There was a problem hiding this comment.
Why are making a shallow copy of the request?
There was a problem hiding this comment.
I didn't want to affect any of the other adapters when I changed the top level currency field for my request
There was a problem hiding this comment.
At this point in code, the request is already exclusive for ConversantAdapter. You will not be affecting any other adapters.
There was a problem hiding this comment.
ok, I removed the shallow copy
There was a problem hiding this comment.
Just checking in. Are there any further changes needed?
adapters/conversant/conversant.go
Outdated
| @@ -18,6 +19,11 @@ type ConversantAdapter struct { | |||
| } | |||
|
|
|||
| func (c *ConversantAdapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.ExtraRequestInfo) ([]*adapters.RequestData, []error) { | |||
| cnvrRequest := *request | |||
| //Backend needs USD or it will reject the request | |||
| if cnvrRequest.Cur != nil && len(cnvrRequest.Cur) > 0 && cnvrRequest.Cur[0] != "USD" { | |||
There was a problem hiding this comment.
Nitpick: There is no need for cnvrRequest.Cur != nil since that check is implicit with len(cnvrRequest.Cur) > 0. In Go, it's ok to take the length of a nil slice.
There was a problem hiding this comment.
that's easy enough I'll fix that
| } else if floor > 0 { | ||
| imp.BidFloorCur = "USD" | ||
| imp.BidFloor = floor | ||
| } |
There was a problem hiding this comment.
Why would the floor not be greater than 0 after a currency conversion?
There was a problem hiding this comment.
I was thinking I didn't want a negative floor, but now I think better to pass it through than mysteriously dropping it. fixed
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
johnwier
force-pushed
the
cnvr_handleforeigncurrency
branch
from
8aea4d1 to
29de66f
Compare
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
johnwier
force-pushed
the
cnvr_handleforeigncurrency
branch
from
2beec19 to
922c620
Compare
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
Code coverage summaryNote:
conversantRefer here for heat map coverage report |
gargcreation1992
approved these changes
Apr 22, 2024
SyntaxNode
changed the title
bsardo
changed the title
Sonali-More-Xandr
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backend server rejects any requests that don't have request.cur set to USD. For now, make the Conversant request, and floors in USD