-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversant: Enable audio requests #3996
Conversation
Code coverage summaryNote:
conversantRefer here for heat map coverage report
|
Is there anything else I'm missing that's blocking this PR? |
@johnwier We're just backlogged with reviews. I do see specific handling for banner and video in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. @johnwier can you confirm that no additional audio specific changes are needed in parseCnvrParams
? We see that there is banner specific and video specific logic there.
yes, I can confirm that. |
Co-authored-by: johwier <[email protected]>
Update yaml file to allow audio media type requests