Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversant: Enable audio requests #3996

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

johnwier
Copy link
Contributor

Update yaml file to allow audio media type requests

Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 10cc7d6

conversant

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/conversant/conversant.go:21:	MakeRequests	93.3%
github.com/prebid/prebid-server/v2/adapters/conversant/conversant.go:84:	parseCnvrParams	97.4%
github.com/prebid/prebid-server/v2/adapters/conversant/conversant.go:155:	MakeBids	92.9%
github.com/prebid/prebid-server/v2/adapters/conversant/conversant.go:190:	getBidType	100.0%
github.com/prebid/prebid-server/v2/adapters/conversant/conversant.go:207:	Builder		100.0%
total:										(statements)	95.7%

@bsardo bsardo changed the title Cnvr Adapter: enable audio requests Conversant: Enable audio requests Nov 4, 2024
@johnwier
Copy link
Contributor Author

Is there anything else I'm missing that's blocking this PR?

@SyntaxNode
Copy link
Contributor

@johnwier We're just backlogged with reviews. I do see specific handling for banner and video in parseCnvrParams. Confirming no special handling is required for audio.

Copy link
Collaborator

@bsardo bsardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. @johnwier can you confirm that no additional audio specific changes are needed in parseCnvrParams? We see that there is banner specific and video specific logic there.

@johnwier
Copy link
Contributor Author

johnwier commented Dec 4, 2024

yes, I can confirm that.

@bsardo bsardo assigned bsardo and unassigned SyntaxNode Dec 6, 2024
@bsardo bsardo merged commit 61c5bad into prebid:master Dec 10, 2024
5 checks passed
scr-oath pushed a commit to scr-oath/prebid-server that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants